[fontbe] Match fonttools behaviour for LigCaret rounding #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating variable FEA the various Feature Writers use otround, since variable FEA syntax does not support floats. This is not an issue with kerning, since glyphsapp does not allow for non-integer kerning values, but it is an issue for LigatureCarets and potentially for other variable mark positions (this needs more investigation)
rsheeter
reviewed
Sep 4, 2024
| // when describing an anchor position we almost always use integers, but | ||
| // for some tests we want to accept floats so we can verify rounding behaviour. | ||
| // we define our own trait and impl it for only these two types so that the | ||
| // compiler doesn't need additional type info when we use int/float literals. |
There was a problem hiding this comment.
This makes me a little uncomfortable but I guess it's not public
There was a problem hiding this comment.
yes this is just for a test helper.
rsheeter
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating variable FEA the various Feature Writers use otround, since variable FEA syntax does not support floats.
This is not an issue with kerning, since glyphsapp does not allow for non-integer kerning values, but it is an issue for LigatureCarets and potentially for other variable mark positions (this needs more investigation)