Add 'serde' feature to read/write-fonts #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
May 9, 2023
rsheeter
approved these changes
May 9, 2023
|
I'm holding out on this because I don't want to merge until I have a clear use. My intended use for this is to create binary dumps of real-world tables that require special handling (extension promotion or table splitting) and then use those in integration tests, but I'm leaving this as a draft until I actually get around to building that infrastructure. |
cmyr
force-pushed
the
serde-write-fonts
branch
2 times, most recently
from
0af4ac3
to
b2aa2ed
Compare
This is intended to be used to serialize test cases in write-fonts; it is also added in read-fonts since write-fonts reuses flags and enums declared in write-fonts. One funny thing: (I think) this hit a serde bug around using non-literals to provide default values for const generics, which we do in the OffsetMarker types in write-fonts.
cmyr
force-pushed
the
serde-write-fonts
branch
from
b2aa2ed
to
3d66eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be used to serialize test cases in write-fonts; it is also added in read-fonts since write-fonts reuses flags and enums declared in read-fonts.
One funny thing: (I think) this hit a serde bug around using non-literals to provide default values for const generics, which we do in the OffsetMarker types in write-fonts; I've opened an issue upstream at serde-rs/serde#2449