Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove LocaFormatWrapper when serde support lands in fontations #448

Closed
cmyr opened this issue Sep 20, 2023 · 1 comment
Closed

remove LocaFormatWrapper when serde support lands in fontations #448

cmyr opened this issue Sep 20, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@cmyr
Copy link
Member

cmyr commented Sep 20, 2023

this is an ugly & annoying hack that we can now avoid.

see googlefonts/fontations#396
@rsheeter rsheeter added the good first issue Good for newcomers label Sep 26, 2023
@cmyr
Copy link
Member Author

cmyr commented Apr 1, 2024

Update: we actually can't avoid this, because the trick we generally use to persist font tables (BeValue) requires the types to implement Validate + FontWrite, and those traits are not implemented for scalar values, and we still can't implement Persistable for LocaFomat directly because of the orpan rules. 😒

@cmyr cmyr closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmyr @rsheeter