Missing LRO mixin in some APIs #781
Labels
sidekick
Issues related to the code generator
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
I am not sure if this is a bug in cloud build, or
sidekick
needs to support services that have LROs but do not have the LRO mixin.google/devtools/cloudbuild/v1
google/bigtable/admin/v2
As noted in #780 the code emitted for
google/devtools/cloudbuild/v1
does not compile.sidekick
is trying to generate the LRO helpers, since there are functions that returngoogle.longrunning.Operation
and have the right annotations:https://github.com/googleapis/googleapis/blob/e9a4c38a81933108eaa6ac96c7ead31e253c8c64/google/devtools/cloudbuild/v1/cloudbuild.proto#L97-L117
However, the service config does not import the mixin:
https://github.com/googleapis/googleapis/blob/e9a4c38a81933108eaa6ac96c7ead31e253c8c64/google/devtools/cloudbuild/v1/cloudbuild_v1.yaml#L1-L15
Without the mixin, there is no
get_operation()
function or builder defined. The generated code assumes these exist. One possible "solution" is to disable the LRO helpers if the mixin does not exist, but I am not sure the generated code would be that useful in that case.Another solution might be to force the mixin when we find LRO-like functions.
The text was updated successfully, but these errors were encountered: