feat(generator): automatic longrunning mixin
#812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services need the `longrunning` mixin, but their service config YAML file does not provide it. Automatically add it when needed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 36 36
Lines 1357 1357
=======================================
Hits 1297 1297
Misses 60 60 ☔ View full report in Codecov by Sentry. |
codyoss
requested changes
Jan 24, 2025
coryan
force-pushed
the
feat-generator-automatic-mixins
branch
from
a39e33b to
45787bd
Compare
coryan
commented
Jan 24, 2025
codyoss
reviewed
Jan 24, 2025
| hasLongrunning := false | ||
| for _, api := range serviceConfig.GetApis() { | ||
| // Only insert the service if needed. We want to preserve the order | ||
| // to make the generated code reproducible, so we cannot use a map. |
There was a problem hiding this comment.
yeah this is a fun Go quirk. I often find myself getting keys, sorting them, and iterating for the same effect. (what you have is fine)
codyoss
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services need the
longrunningmixin, but their service config YAML filedoes not provide it. Automatically add it when needed.
Fixes #781