Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator/rust): implicit LROs mixin #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 26, 2025

Fixes #781 (yes, second time)

If you are wondering how this can possible work: for services with /v1 in the path, the default rules inherited from the mixin work just fine.

I wonder if we should mixin all the methods. Thoughts?

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (25149ad) to head (bb574ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          36       36           
  Lines        1357     1357           
=======================================
  Hits         1297     1297           
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review January 26, 2025 16:19
@coryan coryan requested a review from codyoss January 26, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing LRO mixin in some APIs
1 participant