Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove path filter #10773

Merged
merged 2 commits into from
May 2, 2024
Merged

chore: remove path filter #10773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6424219
chore: remove path filter
JoeWang1127 May 1, 2024
8fd98ed
update the trigger
JoeWang1127 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/hermetic_library_generation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@
# downstream client libraries before they are released.
name: Hermetic library generation upon generation config change through pull requests
on:
workflow_dispatch:
pull_request:
paths:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me what is the trigger now? I guess we don't need it because the logic here should cover all the cases?
I guess it is the same reason we don't allow manual invocation anymore, because manual invocation would not do anything due to no generation_config.yaml change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me what is the trigger now?

Whenever there's a pull request open/edited in the repo, the workflow will be triggered.

We don't need the paths since the script can handle it (the logic you mentioned). All we need is a pull request and manual invocation doesn't have one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, do you mind adding these info to the PR description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

- "generation_config.yaml"

jobs:
library_generation:
Expand Down
Loading