chore: remove path filter #10773
Merged
chore: remove path filter #10773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
May 2, 2024
| pull_request: | ||
| paths: |
There was a problem hiding this comment.
Can you remind me what is the trigger now? I guess we don't need it because the logic here should cover all the cases?
I guess it is the same reason we don't allow manual invocation anymore, because manual invocation would not do anything due to no generation_config.yaml change?
There was a problem hiding this comment.
Can you remind me what is the trigger now?
Whenever there's a pull request open/edited in the repo, the workflow will be triggered.
We don't need the paths since the script can handle it (the logic you mentioned). All we need is a pull request and manual invocation doesn't have one.
There was a problem hiding this comment.
Thanks, do you mind adding these info to the PR description?
blakeli0
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
generation_config.yaml.After merging this PR, the workflow will be triggered whenever there's a pull request is opened or edited so that we can make it required.