Updated mavlink-router installation #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the old method of installing mavlink-router via the
autogen.shscript is deprecated since November 2021 (see mavlink-router/mavlink-router@c8c7c1c). Mavlink-router is now configured and built using meson/ninja.This PR updates the steps for configuring and building mavlink-router to use meson/ninja. The actual installation of the
mavlink-routerdbinary is done by simply copying it from the build directory to its installation destination.This final step of copying the binary into its destination folder replaces the standard way of installing mavlink-router (
sudo ninja -C build install) because ninja installs the service into systemd by default and requires admin rights to do it. This request for admin rights is done through "polkit" which requires manual entry of the admin password which fails through puppet. Also, it does not seem to be possible to disable the installation of the service in systemd as it was possible with the--disable-systemdargument inautogen.sh, so the installation step is actually not desired.This was tested on an Nvidia Xavier NX Dev Kit.