ci: zephyr: execute (real hardware) HIL tests in matrix jobs #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3259343): https://golioth-firmware-sdk-doxygen-dev--pr641-hil-split-mel8rjov.web.app (expires Thu, 17 Oct 2024 13:13:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
mniestroj
force-pushed
the
hil-split
branch
8 times, most recently
from
108953f
to
1b314fa
Compare
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
So far bash 'for' loop was used to iterate through all tests, then build them and run pytest. This produced massive amount of logs and as a result was very hard to find a problem when such occurred. Add job (matrix) that dynamically generates matrix based on the list of tests to execute. Then use matrix strategy to build those tests and run pytest on HIL. Split building and runtime execution into separate steps, so that it improves: * visual feedback in GitHub Actions UI when investigating failed jobs * no $EXITCODE handling * faster execution of "Re-run failed jobs" when only single test on a single platform has failed (it makes it more likely to pass) Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
changed the title
mniestroj
requested review from
sam-golioth and
szczys
and removed request for
sam-golioth
|
Can we get some rough numbers on how much time this adds for a complete test run (ignoring retries)? Let's also identify areas where we can cut down on the per-test overhead. Some of the ones that come to mind (but there could be others):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far bash 'for' loop was used to iterate through all tests, then build
them and run pytest. This produced massive amount of logs and as a result
was very hard to find a problem when such occurred.
Add job (matrix) that dynamically generates matrix based on the list of
tests to execute. Then use matrix strategy to build those tests and run
pytest on HIL.
Split building and runtime execution into separate steps, so that it
improves:
single platform has failed (it makes it more likely to pass)
This PR slightly increases time of the initial run. However since it is very
common that some of those tests do not pass, it is much faster to restart
subset of tests instead of all of them in a loop. In the end this should
reduce time spent on hardware testing.