Skip to content

Commit

Permalink
ci: zephyr: execute (real hardware) HIL tests in matrix jobs
Browse files Browse the repository at this point in the history 
So far bash 'for' loop was used to iterate through all tests, then build
them and run pytest. This produced massive amount of logs and as a result
was very hard to find a problem when such occurred.

Add job (matrix) that dynamically generates matrix based on the list of
tests to execute. Then use matrix strategy to build those tests and run
pytest on HIL.

Split building and runtime execution into separate steps, so that it
improves:
 * visual feedback in GitHub Actions UI when investigating failed jobs
 * no $EXITCODE handling
 * faster execution of "Re-run failed jobs" when only single test on a
   single platform has failed (it makes it more likely to pass)

Signed-off-by: Marcin Niestroj <[email protected]>
  • Loading branch information
@mniestroj
mniestroj committed Oct 4, 2024
1 parent 5f909fe commit 108953f
Showing 1 changed file with 89 additions and 46 deletions.
135 changes: 89 additions & 46 deletions .github/workflows/hil_test_zephyr.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,38 @@ on:
type: string

jobs:
matrix:
name: zephyr-${{ inputs.hil_board }}-matrix
runs-on: ubuntu-latest

outputs:
tests: ${{ steps.output-tests.outputs.tests }}

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Prepare tests matrix
id: output-tests
shell: python
run: |
import json
import os
from pathlib import Path
tests = [p.name for p in Path('tests/hil/tests').iterdir()]
with open(os.environ['GITHUB_OUTPUT'], 'a') as github_output:
print('tests=' + json.dumps(tests), file=github_output)
build:
name: zephyr-${{ inputs.hil_board }}-build
name: zephyr-${{ inputs.hil_board }}-build (${{ matrix.test }})
container: golioth/golioth-zephyr-base:0.16.3-SDK-v0
needs: matrix
strategy:
fail-fast: false
matrix:
test: ${{ fromJSON(needs.matrix.outputs.tests) }}
env:
ZEPHYR_SDK_INSTALL_DIR: /opt/toolchains/zephyr-sdk-0.16.3
runs-on: ubuntu-latest
Expand Down Expand Up @@ -106,20 +135,23 @@ jobs:
export EXTRA_BUILD_ARGS=-DCONFIG_GOLIOTH_COAP_HOST_URI=\"${{ inputs.coap_gateway_url }}\"
for test in $(ls modules/lib/golioth-firmware-sdk/tests/hil/tests)
do
west build -p -b ${{ inputs.west_board }} modules/lib/golioth-firmware-sdk/tests/hil/platform/zephyr -- $EXTRA_BUILD_ARGS -DGOLIOTH_HIL_TEST=$test
mv build/zephyr/${{ inputs.binary_name }} test_binaries/${test}-${{ inputs.binary_name }}
done
west build -p -b ${{ inputs.west_board }} modules/lib/golioth-firmware-sdk/tests/hil/platform/zephyr -- $EXTRA_BUILD_ARGS -DGOLIOTH_HIL_TEST=${{ matrix.test }}
mv build/zephyr/${{ inputs.binary_name }} test_binaries/${{ matrix.test }}-${{ inputs.binary_name }}
- name: Save artifacts
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.hil_board }}-hil-zephyr
name: ${{ inputs.hil_board }}-hil-zephyr-${{ matrix.test }}
path: test_binaries/*

test:
name: zephyr-${{ inputs.hil_board }}-test
needs: build
name: zephyr-${{ inputs.hil_board }}-test (${{ matrix.test }})
needs:
- matrix
- build
strategy:
fail-fast: false
matrix:
test: ${{ fromJSON(needs.matrix.outputs.tests) }}
runs-on: [ is_active, "has_${{ inputs.hil_board }}" ]
timeout-minutes: 30

Expand All @@ -145,7 +177,7 @@ jobs:
- name: Download build
uses: actions/download-artifact@v4
with:
name: ${{ inputs.hil_board }}-hil-zephyr
name: ${{ inputs.hil_board }}-hil-zephyr-${{ matrix.test }}
path: .
- name: Run test
shell: bash
Expand All @@ -158,54 +190,36 @@ jobs:
source /opt/credentials/runner_env.sh
PORT_VAR=CI_${hil_board^^}_PORT
SNR_VAR=CI_${hil_board^^}_SNR
for test in $(ls tests/hil/tests)
do
pytest --rootdir . tests/hil/tests/$test \
--board ${hil_board} \
--port ${!PORT_VAR} \
--fw-image ${test}-${{ inputs.binary_name }} \
--serial-number ${!SNR_VAR} \
--api-url ${{ inputs.api-url }} \
--api-key ${{ secrets[inputs.api-key-id] }} \
--wifi-ssid ${{ secrets[format('{0}_WIFI_SSID', runner.name)] }} \
--wifi-psk ${{ secrets[format('{0}_WIFI_PSK', runner.name)] }} \
--mask-secrets \
--timeout=600 \
--junitxml=summary/hil-zephyr-${{ inputs.hil_board }}-${test}.xml \
--alluredir=allure-reports \
--platform zephyr \
--runner-name ${{ runner.name }} \
|| EXITCODE=$?
done
exit $EXITCODE
- name: Prepare summary
if: always()
shell: bash
run: |
if ! command -v sudo; then
# Self-hosted runner docker images don't have sudo installed
mkdir -p -m 777 /tmp && apt update && apt install -y xml-twig-tools
else
sudo apt install -y xml-twig-tools
fi
xml_grep --pretty_print indented --wrap testsuites --descr '' --cond "testsuite" summary/*.xml > combined.xml
mv combined.xml summary/hil-zephyr-${{ inputs.hil_board }}.xml
pytest --rootdir . tests/hil/tests/${{ matrix.test }} \
--board ${hil_board} \
--port ${!PORT_VAR} \
--fw-image ${{ matrix.test }}-${{ inputs.binary_name }} \
--serial-number ${!SNR_VAR} \
--api-url ${{ inputs.api-url }} \
--api-key ${{ secrets[inputs.api-key-id] }} \
--wifi-ssid ${{ secrets[format('{0}_WIFI_SSID', runner.name)] }} \
--wifi-psk ${{ secrets[format('{0}_WIFI_PSK', runner.name)] }} \
--mask-secrets \
--timeout=600 \
--junitxml=summary/hil-zephyr-${{ inputs.hil_board }}-${{ matrix.test }}.xml \
--alluredir=allure-reports \
--platform zephyr \
--runner-name ${{ runner.name }}
- name: Safe upload CI report summary
uses: ./.github/actions/safe-upload-artifacts
if: always()
with:
name: ci-summary-hil-zephyr-${{ inputs.hil_board }}
path: summary/hil-zephyr-${{ inputs.hil_board }}.xml
name: ci-individual-hil-zephyr-${{ inputs.hil_board }}-${{ matrix.test }}
path: summary/*.xml

- name: Safe upload Allure reports
if: always()
uses: ./.github/actions/safe-upload-artifacts
with:
secrets-json: ${{ toJson(secrets) }}
name: allure-reports-hil-zephyr-${{ inputs.hil_board }}
name: allure-reports-hil-zephyr-${{ inputs.hil_board }}-${{ matrix.test }}
path: allure-reports

- name: Erase flash
Expand Down Expand Up @@ -253,3 +267,32 @@ jobs:
- name: Power Off USB Hub
if: always()
run: python3 /opt/golioth-scripts/usb_hub_power.py off

summary:
name: zephyr-${{ inputs.hil_board }}-summary
runs-on: ubuntu-latest
needs: test

steps:
- name: Collect JUnit reports
uses: actions/download-artifact@v4
with:
path: summary
pattern: ci-individual-hil-zephyr-*
merge-multiple: true

- name: Prepare CI report summary
if: always()
shell: bash
run: |
sudo apt install -y xml-twig-tools
xml_grep --pretty_print indented --wrap testsuites --descr '' --cond "testsuite" summary/*.xml \
> summary/hil-zephyr-${{ inputs.hil_board }}.xml
- name: Safe upload CI report summary
uses: ./.github/actions/safe-upload-artifacts
if: always()
with:
name: ci-summary-hil-zephyr-${{ inputs.hil_board }}
path: summary/hil-zephyr-${{ inputs.hil_board }}.xml

0 comments on commit 108953f

Please sign in to comment.