Add output_path field to Task::Options struct #10
Conversation
kubkon
force-pushed
the
kubkon/output_path
branch
from
162a9b7 to
a51c9d1
Compare
This commit populates the so-far unused `TaskBuilder` options field `output_path` with data from the gWasm task definition. This field is now a required field in the gWasm task's manifest. This commit partially addresses golemfactory/g-flite#28. cc @lukasz.glen FYI, this is a potentially breaking change for the raw gWasm apps in our `wasm-store`. cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33 and golemfactory/gwasm-rust-api#10 should address golemfactory/g-flite#28.
This commit populates the so-far unused `TaskBuilder` options field `output_path` with data from the gWasm task definition. This field is now a required field in the gWasm task's manifest. This commit partially addresses golemfactory/g-flite#28. cc @lukasz-glen FYI, this is a potentially breaking change for the raw gWasm apps in our `wasm-store`. cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33 and golemfactory/gwasm-rust-api#10 should address golemfactory/g-flite#28.
|
On second thought, I think I might make |
There was a problem hiding this comment.
Thanks for the heads up @kubkon. For now I've configured gWASM runner to use a specific git tag instead of a branch (golemfactory/gwasm-runner#25).
The relevant changes on Golem's side are here: https://github.com/golemfactory/golem/pull/4845/.
Sure, as long as there's a reasonable default value provided. |
Hmm, I was actually thinking of leaving the field out completely if it's unspecified. What do you think? |
This commit adds `output_path` field to `Task::Options` struct. This is needed to partially address request golemfactory/g-flite#28. The field is made optional, and serialized only if is not `None`.
kubkon
force-pushed
the
kubkon/output_path
branch
from
a51c9d1 to
308ed34
Compare
|
OK, @zakaprov, if you could have a look at the PR again, that'd be great! :-) |
Fair enough, but I guess that would need to be reflected in https://github.com/golemfactory/golem/pull/4845/, i.e. we should provide a default there. |
Agreed, and that's precisely the change I'm already working on :-) |
This commit overloads the `TaskBuilder`'s `get_output_path` for gWasm tasks. If the task def consists of `output_path` field, then its value is used as the output path of the task. Otherwise, `get_output_path` returns the value of `output_dir` that is supplied within the task def. This commit partially addresses golemfactory/g-flite#28. cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33 and golemfactory/gwasm-rust-api#10 should address golemfactory/g-flite#28.
This commit overloads the `TaskBuilder`'s `get_output_path` for gWasm tasks. If the task def consists of `output_path` field, then its value is used as the output path of the task. Otherwise, `get_output_path` returns the value of `output_dir` that is supplied within the task def. This commit partially addresses golemfactory/g-flite#28. cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33 and golemfactory/gwasm-rust-api#10 should address golemfactory/g-flite#28.
This commit overloads the `TaskBuilder`'s `get_output_path` for gWasm tasks. If the task def consists of `output_path` field, then its value is used as the output path of the task. Otherwise, `get_output_path` returns the value of `output_dir` that is supplied within the task def. This commit partially addresses golemfactory/g-flite#28. cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33 and golemfactory/gwasm-rust-api#10 should address golemfactory/g-flite#28.
This commit adds
output_pathfield toTask::Optionsstruct. Thisis needed to partially address request golemfactory/g-flite#28. The
field is made non-optional as after this change lands in upstream,
it will be required by the Wasm app on the Golem side.
cc @zakaprov FYI that this is a potentially breaking change for Brass
backend in
gwasm-runner.