Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output path of task in Task definition #28

Open
mdtanrikulu opened this issue Oct 17, 2019 · 1 comment
Open

Output path of task in Task definition #28

mdtanrikulu opened this issue Oct 17, 2019 · 1 comment

Comments

@mdtanrikulu
Copy link

Hey hey!

Currently there is no proper output path for g-flite in task definition;

Actual:

options: {
        output_path: 'g_flite_2019-09-17_14-32-17',
        js_name: 'g_flite.js',
        wasm_name: 'g_flite.wasm',
        input_dir: '/var/folders/sl/c58rc1jj0c74xr6mrzqx296m0000gn/T/g_fliteM5oGRB/in',
        output_dir: '/var/folders/sl/c58rc1jj0c74xr6mrzqx296m0000gn/T/g_fliteM5oGRB/out',
       ...
}

Expected (example from blender task definition)

options: {
        frame_count: 1,
        output_path: '/Users/user_name/Documents/golem/Ring_27_2019-10-17_17-34-11',
        ...
      },

Note: /Users/user_name/Documents/golem is default path set in Golem electron in settings tab,
defaullt

it can be any valid path for g-flite. Not necessarly the default path. But of course it's would be nice to have in default path if user didn't specified any.
kubkon pushed a commit to golemfactory/gwasm-rust-api that referenced this issue Oct 31, 2019
Add output_path field to Task::Options struct
b221378 
This commit adds `output_path` field to `Task::Options` struct. This
is needed to partially address request golemfactory/g-flite#28. The
field is made non-optional as after this change lands in upstream,
it will be **required** by the Wasm app on the Golem side.

cc @zakaprov FYI that this is a potentially breaking change for Brass
backend in `gwasm-runner`.
kubkon pushed a commit to golemfactory/gwasm-rust-api that referenced this issue Oct 31, 2019
Add output_path field to Task::Options struct
162a9b7 
This commit adds `output_path` field to `Task::Options` struct. This
is needed to partially address request golemfactory/g-flite#28. The
field is made non-optional as after this change lands in upstream,
it will be **required** by the Wasm app on the Golem side.

cc @zakaprov FYI that this is a potentially breaking change for Brass
backend in `gwasm-runner`.
@kubkon kubkon mentioned this issue Oct 31, 2019
Merged
kubkon pushed a commit to golemfactory/gwasm-rust-api that referenced this issue Oct 31, 2019
Add output_path field to Task::Options struct
a51c9d1 
This commit adds `output_path` field to `Task::Options` struct. This
is needed to partially address request golemfactory/g-flite#28. The
field is made non-optional as after this change lands in upstream,
it will be **required** by the Wasm app on the Golem side.

cc @zakaprov FYI that this is a potentially breaking change for Brass
backend in `gwasm-runner`.
kubkon pushed a commit that referenced this issue Oct 31, 2019
Split output into output_dir and output_filename
92b7e6a 
This commit syncs the app with `gwasm-rust-api` v0.1.2 which now
requires specifying `output_path` field in the `Task::Options`
definition. To achieve this, this commit splits the `output` path
into two subcomponents: `output_dir` and `output_filename`.

This commit partially addresses #28.
@kubkon kubkon mentioned this issue Oct 31, 2019
Merged
kubkon pushed a commit that referenced this issue Oct 31, 2019
Split output into output_dir and output_filename
05613f3 
This commit syncs the app with `gwasm-rust-api` v0.1.2 which now
requires specifying `output_path` field in the `Task::Options`
definition. To achieve this, this commit splits the `output` path
into two subcomponents: `output_dir` and `output_filename`.

This commit partially addresses #28.
kubkon pushed a commit to golemfactory/clay that referenced this issue Oct 31, 2019
Populate output_path with data from Wasm task def
d992827 
This commit populates the so-far unused `TaskBuilder` options field
`output_path` with data from the gWasm task definition. This field
is now a required field in the gWasm task's manifest. This commit
partially addresses golemfactory/g-flite#28.

cc @lukasz.glen FYI, this is a potentially breaking change for the
raw gWasm apps in our `wasm-store`.

cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33
and golemfactory/gwasm-rust-api#10 should address
golemfactory/g-flite#28.
@kubkon kubkon mentioned this issue Oct 31, 2019
Merged
kubkon pushed a commit to golemfactory/clay that referenced this issue Oct 31, 2019
Populate output_path with data from Wasm task def
9a6833c 
This commit populates the so-far unused `TaskBuilder` options field
`output_path` with data from the gWasm task definition. This field
is now a required field in the gWasm task's manifest. This commit
partially addresses golemfactory/g-flite#28.

cc @lukasz-glen FYI, this is a potentially breaking change for the
raw gWasm apps in our `wasm-store`.

cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33
and golemfactory/gwasm-rust-api#10 should address
golemfactory/g-flite#28.
kubkon pushed a commit to golemfactory/gwasm-rust-api that referenced this issue Oct 31, 2019
Add output_path field to Task::Options struct
308ed34 
This commit adds `output_path` field to `Task::Options` struct. This
is needed to partially address request golemfactory/g-flite#28. The
field is made optional, and serialized only if is not `None`.
kubkon pushed a commit to golemfactory/clay that referenced this issue Oct 31, 2019
Overload get_output_path for gWasm tasks
13071e0 
This commit overloads the `TaskBuilder`'s `get_output_path` for
gWasm tasks. If the task def consists of `output_path` field, then
its value is used as the output path of the task. Otherwise,
`get_output_path` returns the value of `output_dir` that is
supplied within the task def.

This commit partially addresses golemfactory/g-flite#28.

cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33
and golemfactory/gwasm-rust-api#10 should address
golemfactory/g-flite#28.
kubkon pushed a commit to golemfactory/gwasm-rust-api that referenced this issue Oct 31, 2019
@kubkon
Add output_path field to Task::Options struct
dd071b9 
This commit adds `output_path` field to `Task::Options` struct. This
is needed to partially address request golemfactory/g-flite#28. The
field is made optional, and serialized only if is not `None`.
kubkon pushed a commit that referenced this issue Oct 31, 2019
Split output into output_dir and output_filename
f5204d8 
This commit syncs the app with `gwasm-rust-api` v0.1.2 which now
requires specifying `output_path` field in the `Task::Options`
definition. To achieve this, this commit splits the `output` path
into two subcomponents: `output_dir` and `output_filename`.

This commit partially addresses #28.
kubkon pushed a commit that referenced this issue Nov 1, 2019
@kubkon
Split output into output_dir and output_filename
f84e518 
This commit syncs the app with `gwasm-rust-api` v0.1.2 which now
requires specifying `output_path` field in the `Task::Options`
definition. To achieve this, this commit splits the `output` path
into two subcomponents: `output_dir` and `output_filename`.

This commit partially addresses #28.
kubkon pushed a commit to golemfactory/clay that referenced this issue Nov 2, 2019
@kubkon
Overload get_output_path for gWasm tasks
b2bcdcf 
This commit overloads the `TaskBuilder`'s `get_output_path` for
gWasm tasks. If the task def consists of `output_path` field, then
its value is used as the output path of the task. Otherwise,
`get_output_path` returns the value of `output_dir` that is
supplied within the task def.

This commit partially addresses golemfactory/g-flite#28.

cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33
and golemfactory/gwasm-rust-api#10 should address
golemfactory/g-flite#28.
kubkon pushed a commit to golemfactory/clay that referenced this issue Nov 2, 2019
@kubkon
Overload get_output_path for gWasm tasks
b1222ed 
This commit overloads the `TaskBuilder`'s `get_output_path` for
gWasm tasks. If the task def consists of `output_path` field, then
its value is used as the output path of the task. Otherwise,
`get_output_path` returns the value of `output_dir` that is
supplied within the task def.

This commit partially addresses golemfactory/g-flite#28.

cc @mdtanrikulu FYI, this commit together with golemfactory/g-flite#33
and golemfactory/gwasm-rust-api#10 should address
golemfactory/g-flite#28.
@kubkon
Copy link
Contributor

kubkon commented Nov 4, 2019

Hey @mdtanrikulu! Thanks for submitting the issue.

So you should now be good to go. The PRs rolling out the required functionality are now merged into their respective upstreams: golemfactory/golem#4845, #33, and golemfactory/gwasm-rust-api#10.

You can proceed to testing if the changes are up to your spec by downloading the latest g-flite binary, and running latest Golem develop from source. After running your tests, lemme know if that's what you were after and if so, feel free to close this issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kubkon @mdtanrikulu