Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(events): add NewEventsFromSlice method #366

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

ecrupper
Copy link
Contributor

This will allow for the CLI and Server and any other user code to more easily generate the AllowEvents struct from a common source of input (a slice).

@ecrupper ecrupper requested a review from a team as a code owner March 21, 2024 14:08
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (b1970b9) to head (f1f3cf0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   96.57%   96.60%   +0.02%     
==========================================
  Files          69       69              
  Lines        5318     5353      +35     
==========================================
+ Hits         5136     5171      +35     
  Misses        109      109              
  Partials       73       73              
Files Coverage Δ
library/events.go 100.00% <100.00%> (ø)

constants/event.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecrupper ecrupper merged commit e9cd33a into main Mar 21, 2024
11 checks passed
@ecrupper ecrupper deleted the enhance/source-events-from-slice branch March 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants