Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): abstract populateEvents for secret usage #542

Closed
wants to merge 1 commit into from

Conversation

ecrupper
Copy link
Contributor

add and update secrets were missing the new AllowEvents functionality. This PR addresses that.

@ecrupper ecrupper requested a review from a team as a code owner March 21, 2024 13:22
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.08%. Comparing base (379fce6) to head (206a8ff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   82.09%   82.08%   -0.01%     
==========================================
  Files         147      148       +1     
  Lines        3635     3633       -2     
==========================================
- Hits         2984     2982       -2     
  Misses        480      480              
  Partials      171      171              
Files Coverage Δ
action/repo/add.go 94.28% <100.00%> (+3.17%) ⬆️
action/repo/update.go 100.00% <100.00%> (ø)
action/secret/add.go 83.33% <100.00%> (+0.47%) ⬆️
action/secret/update.go 83.33% <100.00%> (+0.47%) ⬆️
command/repo/add.go 93.10% <ø> (ø)
command/repo/update.go 93.10% <ø> (ø)
command/secret/add.go 75.00% <ø> (ø)
command/secret/update.go 75.00% <ø> (ø)
internal/events.go 87.75% <87.75%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper
Copy link
Contributor Author

Closing in favor of even further abstraction of this process here: go-vela/types#366

@ecrupper ecrupper closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants