Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(db): return secret on created / updated #928

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

ecrupper
Copy link
Contributor

Continuing effort from these: #861, #882, #884, #913, #915

@ecrupper ecrupper requested a review from a team as a code owner August 15, 2023 17:07
@ecrupper ecrupper self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #928 (15d451a) into main (635c18b) will decrease coverage by 0.33%.
The diff coverage is 53.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   71.40%   71.07%   -0.33%     
==========================================
  Files         304      304              
  Lines       12495    12512      +17     
==========================================
- Hits         8922     8893      -29     
- Misses       3138     3177      +39     
- Partials      435      442       +7     
Files Changed Coverage Δ
database/secret/update.go 60.00% <25.00%> (-15.68%) ⬇️
database/secret/create.go 60.86% <29.41%> (-14.81%) ⬇️
secret/native/update.go 62.50% <66.66%> (ø)
secret/vault/update.go 86.95% <80.00%> (-13.05%) ⬇️
secret/native/create.go 100.00% <100.00%> (ø)
secret/vault/create.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants