Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(db): return step on created and updated #933

Merged
merged 3 commits into from
Aug 23, 2023
Merged

refactor(db): return step on created and updated #933

merged 3 commits into from
Aug 23, 2023

Conversation

ecrupper
Copy link
Contributor

Continuing effort from these: #861, #882, #884, #913, #915, #928, #932

@ecrupper ecrupper self-assigned this Aug 22, 2023
@ecrupper ecrupper requested a review from a team as a code owner August 22, 2023 14:25
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@a980c86). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage        ?   70.89%           
=======================================
  Files           ?      310           
  Lines           ?    12743           
  Branches        ?        0           
=======================================
  Hits            ?     9034           
  Misses          ?     3255           
  Partials        ?      454
Files Changed Coverage Δ
api/build/cancel.go 0.00% <0.00%> (ø)
api/build/clean.go 0.00% <0.00%> (ø)
database/step/create.go 85.00% <80.00%> (ø)
database/step/update.go 85.00% <80.00%> (ø)

KellyMerrick
KellyMerrick approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

plyr4
plyr4 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ecrupper ecrupper merged commit 5f6be5c into main Aug 23, 2023
11 of 12 checks passed
@ecrupper ecrupper deleted the refactor-return-db-step branch August 23, 2023 18:30
@ecrupper ecrupper mentioned this pull request Aug 23, 2023
Merged
@colindean colindean mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees

@ecrupper ecrupper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecrupper @timhuynh94 @KellyMerrick @plyr4