Socket Twig UI #16365
Merged
Socket Twig UI #16365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Result is far superior to the previous regarding the design.
I'm still a bit annoyed seeing a lot of content in renderFromStringTemplate. This method should help with small twig code. The part in showForLocation seems very big for that.
Example, part in showListForItem is fine, location one is, I think, too big.
trasher
previously requested changes
Jan 17, 2024
cedric-anne
requested changes
Jan 17, 2024
|
I cleaned up the UI some more. The form to add sockets from a location and form to add sockets from an item are now the same. Adding from an item no longer shows a button that takes you to another page to add the socket(s). |
orthagh
approved these changes
Jan 22, 2024
cedric-anne
force-pushed
the
ui/twig_migrations_2
branch
from
666518b to
7a8c1db
Compare
cedric-anne
force-pushed
the
ui/twig_migrations_2
branch
from
7a8c1db to
202bf06
Compare
cedric-anne
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Socket-related UI to Twig templates.
Redesigned the form shown on the Sockets tab of Locations. Instead of two forms being shown at the same time, one for adding a single socket and another for adding multiple, there is now only a single form which can switch modes using a slider. For multi-add mode, I also added placeholder text for the two name textboxes to make it clearer to the user how the names are built.