Migrate Socket to Twig

CHANGELOG.md

@@ -202,6 +202,8 @@ The present file will list all changes made to the project; according to the
 - `Glpi\Api\API::returnSanitizedContent()`
 - `Glpi\Dashboard\Widget::getCssGradientPalette()`
 - `Glpi\Inventory\Conf::importFile()`
+- `Glpi\Socket::executeAddMulti()`
+- `Glpi\Socket::showNetworkPortForm()`
 - `Glpi\System\Requirement\DataDirectoriesProtectedPath` class.
 - `Glpi\System\Requirement\ProtectedWebAccess` class.
 - `Glpi\System\Requirement\SafeDocumentRoot` class.

front/socket.form.php

@@ -161,7 +161,6 @@
     }
 
    // Add a socket from item : format data
-   // see Socket::showNetworkPortForm()
     if (
         isset($_REQUEST['_add_fromitem'])
         && isset($_REQUEST['_from_itemtype'])

src/Dropdown.php

@@ -36,6 +36,7 @@
 use Glpi\Application\View\TemplateRenderer;
 use Glpi\DBAL\QueryExpression;
 use Glpi\DBAL\QueryFunction;
+use Glpi\Features\DCBreadcrumb;
 use Glpi\Plugin\Hooks;
 use Glpi\SocketModel;
 
@@ -367,7 +368,8 @@ public static function show($itemtype, $options = [])
             }
 
             if ($params['display_dc_position']) {
-                if ($rack = $item->isRackPart($itemtype, $params['value'], true)) {
+                /** @var DCBreadcrumb $item */
+                if ($rack = $item->getParentRack()) {
                     $dc_icon = "<span id='" . $breadcrumb_id . "' title='" . __s('Display on datacenter') . "'>";
                     $dc_icon .= "&nbsp;<a class='fas fa-crosshairs' href='" . $rack->getLinkURL() . "'></a>";
                     $dc_icon .= "</span>";