-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add plot_pfid plot function #283
Conversation
Module containing PFID (Perturbed Free Induction Decay) plotting functionality
Was introduced in `b66f2f2fb0f658b3d105bb6ab40e0e046ffdf28e` "inverse plot order of spectra"
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 44.77% 42.84% -1.94%
==========================================
Files 27 28 +1
Lines 1043 1146 +103
Branches 162 184 +22
==========================================
+ Hits 467 491 +24
- Misses 568 647 +79
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
- Remove unused offset - Remove legend by default, only add back to top left by default - More sensible figsize - Improve util function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did a peer review in a call and LGTM
Ship it 🚀
Module containing PFID (Perturbed Free Induction Decay) plotting functionality
Change summary
condense_numbered_strings
utility function to condense plot labels (e.g. osc1,osc2 -> osc1-2)Checklist
Example screenshots
plot_pfid
withshow_clps=False
plot_pfid
withshow_clps=True