[WIP] ✨ Try out plot-config (rebased after plot_pfid) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| from __future__ import annotations | ||
|
|
||
| import inspect |
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
===========================================
+ Coverage 44.77% 58.01% +13.24%
===========================================
Files 27 31 +4
Lines 1043 1603 +560
Branches 162 290 +128
===========================================
+ Hits 467 930 +463
- Misses 568 657 +89
- Partials 8 16 +8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
✨ Add PlotLabelOverRideValue and PlotLabelOverRideMap
🩹 Fix mutation of input values in plot config
🚇👌 Use non editable install in CI (closer to user how users run it)
This prevents the folloing warning when running the tests: RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (`matplotlib.pyplot.figure`) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam `figure.max_open_warning`). Consider using `matplotlib.pyplot.close()`.
👌 Improve error collection and messages
👌 Make Config.reload lazy (only reloaded when files changed) 👌 Make Config.reload respect plot_config_context
This allows users to pass a tuple of kwarg names (exclude_from_config) that should be ignored when generating the json schema
Correcting `PlotLabelOverRideMap` -> `PlotLabelOverrideMap`
It should be Overdue not OverDue (in OverDueDeprecationError). The word "overdue" is a single word and should not be split into "Over" and "Due" in the class name.
Makes the test more readable, more clear what the test should test and remove a lot of redundant info, and avoid ugly indentation.
🧹 Remove hard coded paths in favor of fixtures
This ensures that if matplotlib injects a newline because the label is to long to fit it still gets replaced
This ensures consistent behaviour in notebooks and scripts.
♻️ Factor out yaml string and markdown method adding into a decorator
Posix and windows have different python installation folder layouts, which caused tests fail since the correct importlib path couldn't be determined on posix systems
jsnel
force-pushed
the
plot_pfid_and_config
branch
from
3aa3f62 to
5a1b6ed
Compare
for more information, see https://pre-commit.ci
jsnel
force-pushed
the
plot_pfid_and_config
branch
from
5d50160 to
9734619
Compare
jsnel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of the plot_config branch after the plot_pfid function was merged into main.