Adds a .Env function on syslog messages #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfuentes
force-pushed
the
add-env-template-option
branch
from
4f39700 to
8378e4d
Compare
|
👍 👍 this would be really handy. |
|
Any feedback on adding this feature? Would be really useful on ECS, thanx |
|
I found a solution using labels on ECS and the SYSLOG_TAG environment variable of logspout: SYSLOG_TAG="{{ index .Container.Config.Labels "com.amazonaws.ecs.container-name" }}" |
|
Look at #182, it should solve this problem and can be changed at runtime to the desired .Env key you want |
- This allows you to use docker container environment variables in the templates for things like SYSLOG_TAG
dfuentes
force-pushed
the
add-env-template-option
branch
from
8378e4d to
173058a
Compare
|
Closing this, it's pretty old at this point, and I no longer use logspout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know the usual method to do changes like this is rolling a custom logspout container with our modified syslog adapter module, but I thought this change might be generally useful.
We've run into the issue where we want to add some container specific information to our log lines, but don't have control of either the container hostname or container name (we are on mesos/marathon). Allowing using container environment variables in the syslog configuration templates (i.e. SYSLOG_TAG) allows us to pull in this custom info.