Add pre-defined environment variables to task definition. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
gliderlabs/logspout#100 kinda blocks this for now. Might just fork logspout. |
ejholmes
added a commit
that referenced
this pull request
May 26, 2015
Add pre-defined environment variables to task definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a temporary workaround for the lack of support for labels in ECS. If we merge this, then we can change the
SYSLOG_STRUCTURED_DATAenvironment variable in logspout to extract these specific variables into the structured-data fields in log messages. EZPZ log filtering for app name, version and process type.Soon the ecs agent will add the task arn, container-name, family and version as well. Once ECS supports adding labels to task definitions, then we can move these to labels like
com.remind.empire.appname,com.remind.empire.process,com.remind.empire.release.Related to #445