Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace javax package by jakarta package #947

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Conversation

jmini
Copy link
Collaborator

@jmini jmini commented Apr 11, 2023

This is the main requested change to be compatible with Spring Boot 3

  • Replace javax.* packages by jakarta.* package
  • Update newer Jakarta EE libraries (jersey, servlet, activation, ...)

Based on the work of @gedeffe in #943

Fixes #894
Fixes #888


In order to work with the proposed git flow (see #926 (comment)) this PR has to be merged with "Create a merge commit" (and not with "Squash and merge")

@jabby jabby self-requested a review April 12, 2023 13:02
jmini and others added 5 commits April 12, 2023 15:36
* Added hook and fetch capabilities

* Fix tests

* Remove superfluous formatting
* Added ReleaseLinks API (gitlab4j#639)

* Deprecate the "external" attribute in Link

* Add tests

* Rename to ReleaseLinksApi and add the getter in GitLabApi

---------

Co-authored-by: Jeremie Bresson <[email protected]>
@jmini
Copy link
Collaborator Author

jmini commented Apr 12, 2023

@jabby I have merged origin/main in the PR after the addition added with #640.

If this is OK for you, it can be merged with "Create a merge commit" (and not "Squash and merge") to preserve the merge information between our two branches.

Then a version 6.0.0-alpha.1 or 6.0.0-rc.1 could be released so that the Spring community can give feedback.

@jabby
Copy link
Collaborator

jabby commented Apr 12, 2023

Thanks @jmini 6.0.0-rc.1 seems a good idea.

@jabby jabby merged commit b404e8a into gitlab4j:6.x Apr 12, 2023
Copy link
Collaborator

@jabby jabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tubbynl
Copy link
Contributor

tubbynl commented Apr 12, 2023

tnx for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants