Compatibility with Spring Boot 3.x #943
Conversation
In order to work with Spring Boot 3.x, transition from javax to jakarta is mandatory. It involves also an update of target jdk.
| /** | ||
| * This class implements the client side API for the GitLab Application Settings API. | ||
| * See <a href="https://docs.gitlab.com/ee/api/settings.html">Application Settings API at GitLab</a> for more information. | ||
| */ | ||
| public class ApplicationSettingsApi extends AbstractApi { | ||
|
|
||
| public ApplicationSettingsApi(GitLabApi gitLabApi) { | ||
| public ApplicationSettingsApi(final GitLabApi gitLabApi) { |
There was a problem hiding this comment.
Why did you make all the method argument explicitly final?
I think the compiler was already treating those as implicitly final
If we keep the vision to have 2 active branches main and 6.x, this kind of changes will make keeping both branch working in parallel too complicated.
There was a problem hiding this comment.
You're right.
Sorry, this is an automatic config of IntelliJ (clean-up tasks)
| @@ -297,7 +296,8 @@ | |||
| <configuration> | |||
| <signature> | |||
| <groupId>org.codehaus.mojo.signature</groupId> | |||
| <artifactId>java1${java.level}</artifactId> | |||
| <artifactId>java18</artifactId> | |||
There was a problem hiding this comment.
Per mojohaus/animal-sniffer#62, keeping animal-sniffer when building with Java 11 does not really make sense.
There was a problem hiding this comment.
So, we would be able to remove this configuration ?
There was a problem hiding this comment.
This is what I did in #946 (keeping you are co-author of the change)
If I understand correctly, it would be better to target branch 6.x for these evolutions ? |
|
@gedeffe I am splitting your work in smaller PRs.
I have posted the Git flow I would like to use in this project in #926 (comment) Compared to your work, I am also removing all the code formatting and other non-necessary changes in order to keep both branches close enough... |
|
@jmini , Thank you for integration in branch 6.x, especially as I made noise with automatic format of code (like adding final keyword). Do I have to keep this PR alive, or should I edit it to target only 6.x branch or close it ? |
|
@ajivemu: Please check if the release This version is using:
|
I have open 3 PRs with all your ideas from this PR. You can review the last open one #950 and tell if something is missing. For me this PR can be closed. Thank you very much for your work. |
|
And I forgot to mention also here that version 6.0.0-rc.1 works for our use cases. |
In order to use gitlab4j-api with new version of SpringBoot and related dependencies, we had to upgrade several libraries.
It implies also a move from javax.xxx to jakarta.xxx for JEE libraries.
Relates to existing issues: