Add Python #282

hendrikvanantwerpen · 2023-06-02T10:48:31Z

This adds rules for Python based on a legacy specification written in a precursor of tree-sitter-stack-graphs.

github-actions · 2023-11-15T11:54:20Z

Performance Summary

Comparing base 3696992 with head 5776934 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
3.276^                                                                     :# 
     |                                                                     :# 
     |                                                                     :# 
     |                                                                     :#:
     |                                                                     :#:
     |                                                                     :#:
     |                                             :::@                : :::#:
     |                                             :  @                ::: :#:
     |                                          @@@:  @               :::: :#:
     |                                       :::@  :  @               :::: :#:
     |                                 @    ::  @  :  @        ::@:  @:::: :#:
     |             ::: ::@     :    ::@@:::@::  @  :  @       :::@:::@:::: :#:
   0 +----------------------------------------------------------------------->Gi
     0                                                                   74.84

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
3.276^                                                                     :# 
     |                                                                     :# 
     |                                                                     :# 
     |                                                                     :#:
     |                                                                     :#:
     |                                                                     :#:
     |                                             :::@                : :::#:
     |                                             :  @                ::: :#:
     |                                          @@@:  @               :::: :#:
     |                                       :::@  :  @               :::: :#:
     |                                @@    ::  @  :  @         :@   @:::: :#:
     |              : ::::     :     :@@:::@::  @  :  @       :::@:::@:::: :#:
   0 +----------------------------------------------------------------------->Gi
     0                                                                   74.84

github-actions · 2023-11-30T23:13:03Z

Performance Summary

Comparing base 1b01a8c with head 696981c on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.406^                                               #                        
     |                                               #                      : 
     |                                             ::#                      : 
     |                                          :::: #                      : 
     |                                          : :: #                      : 
     |                                          : :: #                  ::::: 
     |                                         :: :: #                  :   : 
     |                                  @:    ::: :: #         :::     @:   : 
     |                    @             @:    ::: :: #         :@:   ::@:   : 
     |              :    @@           @:@:   :::: :: #        ::@: : : @:   : 
     |              : @::@@     :     @:@:::::::: :: #       :::@::::: @:   : 
     |             @::@::@@ :::::     @:@:::::::: :: #   :   :::@::::: @:   : 
   0 +----------------------------------------------------------------------->Gi
     0                                                                   71.31

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.406^                                               #                        
     |                                               #                      : 
     |                                             ::#                      : 
     |                                          ::@: #                      : 
     |                                          : @: #                      : 
     |                                          : @: #                 :::::: 
     |                                         :: @: #                 :    : 
     |                                   :    ::: @: #         ::@     :    : 
     |                    @             ::    ::: @: #         ::@   @::    : 
     |              @:   :@            :::  ::::: @: #        :::@ ::@ :    : 
     |              @ ::::@     :     ::::::::::: @: #       ::::@:::@ :    : 
     |             @@ ::::@ ::@::    :::::::::::: @: # :  :  @:::@:::@ :    : 
   0 +----------------------------------------------------------------------->Gi
     0                                                                   71.28

github-actions · 2023-12-01T10:23:49Z

Performance Summary

Comparing base 1b01a8c with head 155beb8 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.406^                                               #                        
     |                                               #                      : 
     |                                             ::#                      : 
     |                                          :::: #                      : 
     |                                          : :: #                      : 
     |                                          : :: #                  ::::: 
     |                                         :: :: #                  :   : 
     |                                  @:    ::: :: #         :::     @:   : 
     |                    @             @:    ::: :: #         :@:   ::@:   : 
     |              :    @@           @:@:   :::: :: #        ::@: : : @:   : 
     |              : @::@@     :     @:@:::::::: :: #       :::@::::: @:   : 
     |             @::@::@@ :::::     @:@:::::::: :: #   :   :::@::::: @:   : 
   0 +----------------------------------------------------------------------->Gi
     0                                                                   71.31

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.702^                                              :::#                      
     |                                              :  #                      
     |                                              :  #                      
     |                                              :  #                     :
     |                                           ::::  #                    ::
     |                                        ::@:  :  #                    ::
     |                                        : @:  :  #                @@@@::
     |                                       :: @:  :  #                @   ::
     |                                  :   ::: @:  :  #         ::     @   ::
     |                   @            @::   ::: @:  :  #        :@:  :::@   ::
     |             :   ::@     @     :@:::::::: @:  :  #       ::@::::: @   ::
     |            @::::::@ :  :@   : :@:::::::: @:  :  #   :  :::@::::: @   ::
   0 +----------------------------------------------------------------------->Gi
     0                                                                   74.30

github-actions · 2024-01-11T19:34:36Z

Performance Summary

Comparing base 1b01a8c with head 155beb8 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.702^                                            :::#                        
     |                                            :  #                        
     |                                            :  #                        
     |                                            :  #                    ::::
     |                                          :::  #                   ::: :
     |                                         :: :  #                   ::: :
     |                                       :::: :  #                   ::: :
     |                                       : :: :  #                   ::: :
     |                                @@   ::: :: :  #        :::    ::::::: :
     |                   @           :@@   : : :: :  #        :::  :::   ::: :
     |             ::: ::@    :      :@@:::: : :: :  #       ::::@:: :   ::: :
     |            @::::::@ : :: :   ::@@: :: : :: :  #       ::::@:: :   ::: :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   74.10

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.702^                                            :::##                       
     |                                            :  #                        
     |                                            :  #                        
     |                                            :  #                       @
     |                                          :::  #                   ::::@
     |                                       :::: :  #                   :   @
     |                                       : :: :  #                   :   @
     |                                       : :: :  #                   :   @
     |                                 @   ::: :: :  #          :    :::::   @
     |                   @@           :@ : : : :: :  #        :::  :::   :   @
     |              @::::@    ::     ::@:::: : :: :  #        :::::: :   :   @
     |             @@: ::@ : ::     :::@:::: : :: :  #      :::::::: :   :   @
   0 +----------------------------------------------------------------------->Gi
     0                                                                   74.08

github-actions · 2024-01-18T14:19:24Z

Performance Summary

Comparing base 1b01a8c with head e743a67 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.702^                                            :::#                        
     |                                            :  #                        
     |                                            :  #                        
     |                                            :  #                    ::::
     |                                          :::  #                   ::: :
     |                                         :: :  #                   ::: :
     |                                       :::: :  #                   ::: :
     |                                       : :: :  #                   ::: :
     |                                @@   ::: :: :  #        :::    ::::::: :
     |                   @           :@@   : : :: :  #        :::  :::   ::: :
     |             ::: ::@    :      :@@:::: : :: :  #       ::::@:: :   ::: :
     |            @::::::@ : :: :   ::@@: :: : :: :  #       ::::@:: :   ::: :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   74.10

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.702^                                            @@@#                        
     |                                            @  #                        
     |                                            @  #                        
     |                                            @  #                    ::::
     |                                          ::@  #                    @  :
     |                                       :::: @  #                    @  :
     |                                       : :: @  #                ::::@  :
     |                                       : :: @  #                :   @  :
     |                                @@   ::: :: @  #          :     :   @  :
     |                                @@  :: : :: @  #        :::   :::   @  :
     |              :@  :      ::    :@@:::: : :: @  #       :: :@@:: :   @  :
     |              :@:::: :  ::    ::@@: :: : :: @  #       :: :@ :: :   @  :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   73.69

…ition

github-actions · 2024-01-29T15:34:19Z

Performance Summary

Comparing base 1b01a8c with head 5a63def on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.702^                                            :::#                        
     |                                            :  #                        
     |                                            :  #                        
     |                                            :  #                    ::::
     |                                          :::  #                   ::  :
     |                                       :::: :  #                   ::  :
     |                                       : :: :  #                   ::  :
     |                                      :: :: :  #                   ::  :
     |                                 @   @:: :: :  #         ::    ::::::  :
     |                   @           ::@ : @:: :: :  #        :::  :::   ::  :
     |             @:::::@    ::     ::@:::@:: :: :  #        :::::: :   ::  :
     |            @@::: :@ :::: : : :::@:::@:: :: :  #       ::::::@ :   ::  :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   74.09

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.702^                                            :::#                        
     |                                            :  #                        
     |                                            :  #                        
     |                                            :  #                    ::::
     |                                          :::  #                   ::  :
     |                                       :::: :  #                   ::  :
     |                                       : :: :  #                :::::  :
     |                                      :: :: :  #                :  ::  :
     |                                 @   ::: :: :  #          :     :  ::  :
     |                               :@@  :::: :: :  #        :@:   @@:  ::  :
     |              @  :::    :     ::@@ ::::: :: :  #       ::@::::@ :  ::  :
     |             @@::::: @@:: : : ::@@:::::: :: :  #      :::@::::@ :  ::  :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   73.77

Upgrade Python

This reverts commit c16b8cf, reversing changes made to 8e99165.

hendrikvanantwerpen self-assigned this Jun 2, 2023

hendrikvanantwerpen changed the base branch from main to test-timeout June 2, 2023 15:14

hendrikvanantwerpen force-pushed the add-python branch from 49b8e15 to c32cab6 Compare June 2, 2023 15:14

Base automatically changed from test-timeout to main June 2, 2023 15:33

hendrikvanantwerpen force-pushed the add-python branch 2 times, most recently from 6138853 to f88f237 Compare June 8, 2023 10:55

hendrikvanantwerpen removed their assignment Jul 3, 2023

hendrikvanantwerpen force-pushed the add-python branch from f88f237 to ffd81bf Compare August 2, 2023 13:17

hendrikvanantwerpen force-pushed the add-python branch 2 times, most recently from 7e5b158 to 7f506ec Compare November 15, 2023 10:40

hendrikvanantwerpen force-pushed the add-python branch from 6699720 to 0dd2b08 Compare November 30, 2023 23:07

hendrikvanantwerpen mentioned this pull request Nov 30, 2023

Upgrade Python #358

Merged

hendrikvanantwerpen force-pushed the add-python branch from 0dd2b08 to fdf5a45 Compare December 1, 2023 10:18

hendrikvanantwerpen self-assigned this Dec 4, 2023

hendrikvanantwerpen marked this pull request as ready for review December 4, 2023 12:43

hendrikvanantwerpen requested a review from a team as a code owner December 4, 2023 12:43

hendrikvanantwerpen force-pushed the add-python branch from 7ee2c7e to 3391d3b Compare January 18, 2024 14:11

hendrikvanantwerpen added 8 commits January 29, 2024 16:27

Add initial Python language project

30d216f

Add legacy queries and tests for reference

75a3ec5

convert: copy old

decf584

convert: attr syntax

edfe903

convert: no_span

58c67fd

convert: more attr syntax

a830ef5

convert: pop_scoped_symbol

d5a97bd

convert: push symbol

01cf05d

hendrikvanantwerpen added 19 commits January 29, 2024 16:27

Don't crash visualization on self edges

5a63def

Cleanup accidental self loop

fe70ba0

Fix module start lines and do not expect definitions at assertion pos…

dbfb172

…ition

Factor out identifier rules

2d8fd6b

Add bug test

fd57fbd

Fix Python grammar versions

2f619fa

Remove obsolete nodes because of general identifier rules

aae723f

Fix rule to make it similar to others

0b54f6c

Reuse general definition for parameters

a899983

Lower .before_scope and .after_scope

1668eec

Lower .input and .output

e1a0dcf

Lower more nodes

94365dc

Lower final set of nodes

bb0f034

Add tests

d15cb9b

Update README

34eba6e

Upgrade Python and reorganize rules according to syntax categories

c23f7ca

Reorganize imports

41c8f32

Fix parameter definitions

9135ff5

Fixes for pattern identifiers

0f4bf9b

hendrikvanantwerpen force-pushed the add-python branch from 0b2fe70 to 34eba6e Compare January 29, 2024 15:28

hendrikvanantwerpen mentioned this pull request Jan 29, 2024

Python Old DSL -> New DSL #379

Open

Merge pull request #358 from github/upgrade-python

cd9f3eb

Upgrade Python

BekaValentine approved these changes Jan 29, 2024

View reviewed changes

BekaValentine merged commit c16b8cf into main Jan 29, 2024
12 checks passed

BekaValentine deleted the add-python branch January 29, 2024 18:04

BekaValentine added a commit that referenced this pull request Feb 7, 2024

Revert "Merge pull request #282 from github/add-python"

9e4b686

This reverts commit c16b8cf, reversing changes made to 8e99165.

BekaValentine added a commit that referenced this pull request Feb 7, 2024

Revert "Merge pull request #282 from github/add-python"

682c83b

This reverts commit c16b8cf, reversing changes made to 8e99165.

BekaValentine added a commit that referenced this pull request Feb 7, 2024

Revert "Merge pull request #282 from github/add-python"

a0091a0

This reverts commit c16b8cf, reversing changes made to 8e99165.

BekaValentine added a commit that referenced this pull request Feb 7, 2024

Revert "Merge pull request #282 from github/add-python"

3a2800b

This reverts commit c16b8cf, reversing changes made to 8e99165.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Python #282

Add Python #282

hendrikvanantwerpen commented Jun 2, 2023 •

edited

Loading

github-actions bot commented Nov 15, 2023

github-actions bot commented Nov 30, 2023

github-actions bot commented Dec 1, 2023

github-actions bot commented Jan 11, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jan 29, 2024

Add Python #282

Add Python #282

Conversation

hendrikvanantwerpen commented Jun 2, 2023 • edited Loading

github-actions bot commented Nov 15, 2023

Performance Summary

github-actions bot commented Nov 30, 2023

Performance Summary

github-actions bot commented Dec 1, 2023

Performance Summary

github-actions bot commented Jan 11, 2024

Performance Summary

github-actions bot commented Jan 18, 2024

Performance Summary

github-actions bot commented Jan 29, 2024

Performance Summary

hendrikvanantwerpen commented Jun 2, 2023 •

edited

Loading