Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Old DSL -> New DSL #379

Open
BekaValentine opened this issue Jan 26, 2024 · 1 comment
Open

Python Old DSL -> New DSL #379

BekaValentine opened this issue Jan 26, 2024 · 1 comment

Comments

@BekaValentine
Copy link
Contributor

We should move Python over to the new DSL and remove the old DSL

@hendrikvanantwerpen
Copy link
Collaborator

Summary of the work I've done towards this already.

Two PRs exist for the stack graphs repo:

One PR exists on the Aleph repo:

The main difference between old & new DSL to be aware of when making the switch is the effect of graph pruning in the old DSL. Because of the pruning, the rules didn't have to be careful about which identifiers were definitions and which weren't. Pop nodes were created for many reference identifiers, but pruning ensured they never showed up. The new DSL does not prune, so if a pop is created for a reference, it will show up as a result in the UI when clicking the reference! The second stack graphs PR does work to make the rules more precise in that regard, which is important for a good UI experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants