Rust: expand derive macros #19824
Rust: expand derive macros #19824
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -6,6 +6,7 @@ | |||
| import codeql.files.FileSystem | |||
| import codeql.rust.elements.Abi | |||
| import codeql.rust.elements.Addressable | |||
| import codeql.rust.elements.Adt | |||
Check warning
Code scanning / CodeQL
Redundant import Warning
| */ | ||
|
|
||
| private import internal.AdtImpl | ||
| import codeql.rust.elements.Item |
Check warning
Code scanning / CodeQL
Redundant import Warning
|
|
||
| private import internal.AdtImpl | ||
| import codeql.rust.elements.Item | ||
| import codeql.rust.elements.MacroItems |
Check warning
Code scanning / CodeQL
Redundant import Warning
| """ | ||
| An ADT (Abstract Data Type) definition, such as `Struct`, `Enum`, or `Union`. | ||
| """ | ||
| derive_macro_expansions: list[MacroItems] | child | rust.detach |
There was a problem hiding this comment.
Why is this not generated from the rust.ungram? https://github.com/rust-lang/rust-analyzer/blob/master/crates/syntax/rust.ungram#L278-L284
There was a problem hiding this comment.
Ah I see, perhaps we should remove
codeql/rust/ast-generator/src/main.rs
Line 488 in 8c2bda3
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| from .prelude import * | |||
|
|
|||
| class Adt(AstNode, ): | |||
There was a problem hiding this comment.
that's already done in the annotations
codeql/rust/schema/annotations.py
Line 19 in 52c0028
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| from .prelude import * | |||
|
|
|||
| class Adt(AstNode, ): | |||
There was a problem hiding this comment.
Thanks! Your are changing things faster than I can review them ;-)
| (Struct, $self:ident, $node:ident, $label:ident) => { | ||
| $self.emit_derive_expansion($node, $label); | ||
| $self.extract_canonical_origin($node, $label.into()); | ||
| }; |
There was a problem hiding this comment.
Would a single block like this work?
(Adt, $self:ident, $node:ident, $label:ident) => {
$self.emit_derive_expansion($node, $label);
};
There was a problem hiding this comment.
no, because the macro needs to exactly match the concrete type to kick in.
If we had trait specializations we could whip something up like that.
aibaars
force-pushed
the
redsun82/rust-derive-macro-expansion
branch
from
9f6e446 to
f4bdd4d
Compare
No description provided.