Skip to content

Commit 8c2bda3

Browse files
NapalysNapalys
authored
Merge pull request #19776 from Napalys/js/mass_quality_promotion
JS: Mass promotion of queries to `quality` status
2 parents 529b6a5 + 7c25bcd commit 8c2bda3

File tree

97 files changed

+428
-110
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

97 files changed

+428
-110
lines changed

‎javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected

Lines changed: 89 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,98 @@
1+
ql/javascript/ql/src/AngularJS/DependencyMismatch.ql
2+
ql/javascript/ql/src/AngularJS/DuplicateDependency.ql
3+
ql/javascript/ql/src/AngularJS/IncompatibleService.ql
4+
ql/javascript/ql/src/AngularJS/MissingExplicitInjection.ql
5+
ql/javascript/ql/src/AngularJS/RepeatedInjection.ql
6+
ql/javascript/ql/src/AngularJS/UseNgSrc.ql
7+
ql/javascript/ql/src/DOM/DuplicateAttributes.ql
8+
ql/javascript/ql/src/DOM/MalformedIdAttribute.ql
9+
ql/javascript/ql/src/DOM/PseudoEval.ql
10+
ql/javascript/ql/src/Declarations/ArgumentsRedefined.ql
11+
ql/javascript/ql/src/Declarations/AssignmentToConst.ql
12+
ql/javascript/ql/src/Declarations/ClobberingVarInit.ql
13+
ql/javascript/ql/src/Declarations/ConflictingFunctions.ql
14+
ql/javascript/ql/src/Declarations/DeadStoreOfLocal.ql
15+
ql/javascript/ql/src/Declarations/DeadStoreOfProperty.ql
16+
ql/javascript/ql/src/Declarations/DeclBeforeUse.ql
17+
ql/javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql
18+
ql/javascript/ql/src/Declarations/DuplicateVarDecl.ql
119
ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql
20+
ql/javascript/ql/src/Declarations/MissingThisQualifier.ql
21+
ql/javascript/ql/src/Declarations/MissingVarDecl.ql
22+
ql/javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql
223
ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql
24+
ql/javascript/ql/src/Declarations/TemporalDeadZone.ql
25+
ql/javascript/ql/src/Declarations/UniqueParameterNames.ql
26+
ql/javascript/ql/src/Declarations/UniquePropertyNames.ql
27+
ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql
28+
ql/javascript/ql/src/Declarations/UnusedVariable.ql
29+
ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql
30+
ql/javascript/ql/src/Expressions/DuplicateCondition.ql
31+
ql/javascript/ql/src/Expressions/DuplicateProperty.ql
32+
ql/javascript/ql/src/Expressions/DuplicateSwitchCase.ql
333
ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql
34+
ql/javascript/ql/src/Expressions/HeterogeneousComparison.ql
35+
ql/javascript/ql/src/Expressions/ImplicitOperandConversion.ql
436
ql/javascript/ql/src/Expressions/MissingAwait.ql
37+
ql/javascript/ql/src/Expressions/MissingDotLengthInComparison.ql
38+
ql/javascript/ql/src/Expressions/MissingSpaceInAppend.ql
39+
ql/javascript/ql/src/Expressions/MisspelledVariableName.ql
40+
ql/javascript/ql/src/Expressions/RedundantExpression.ql
41+
ql/javascript/ql/src/Expressions/SelfAssignment.ql
42+
ql/javascript/ql/src/Expressions/ShiftOutOfRange.ql
43+
ql/javascript/ql/src/Expressions/StringInsteadOfRegex.ql
44+
ql/javascript/ql/src/Expressions/SuspiciousInvocation.ql
45+
ql/javascript/ql/src/Expressions/SuspiciousPropAccess.ql
46+
ql/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql
47+
ql/javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql
48+
ql/javascript/ql/src/Expressions/UnknownDirective.ql
49+
ql/javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql
50+
ql/javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql
51+
ql/javascript/ql/src/LanguageFeatures/BadTypeof.ql
52+
ql/javascript/ql/src/LanguageFeatures/ConditionalComments.ql
53+
ql/javascript/ql/src/LanguageFeatures/DeleteVar.ql
54+
ql/javascript/ql/src/LanguageFeatures/ExpressionClosures.ql
55+
ql/javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql
56+
ql/javascript/ql/src/LanguageFeatures/IllegalInvocation.ql
57+
ql/javascript/ql/src/LanguageFeatures/InconsistentNew.ql
58+
ql/javascript/ql/src/LanguageFeatures/InvalidPrototype.ql
59+
ql/javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql
60+
ql/javascript/ql/src/LanguageFeatures/NonLinearPattern.ql
61+
ql/javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql
62+
ql/javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql
63+
ql/javascript/ql/src/LanguageFeatures/SetterReturn.ql
564
ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
65+
ql/javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql
66+
ql/javascript/ql/src/LanguageFeatures/SyntaxError.ql
667
ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql
68+
ql/javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql
69+
ql/javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql
70+
ql/javascript/ql/src/LanguageFeatures/WithStatement.ql
71+
ql/javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql
72+
ql/javascript/ql/src/NodeJS/InvalidExport.ql
73+
ql/javascript/ql/src/NodeJS/MissingExports.ql
774
ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql
75+
ql/javascript/ql/src/React/DirectStateMutation.ql
76+
ql/javascript/ql/src/React/InconsistentStateUpdate.ql
77+
ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql
78+
ql/javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql
79+
ql/javascript/ql/src/RegExp/BackrefBeforeGroup.ql
80+
ql/javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql
881
ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql
82+
ql/javascript/ql/src/RegExp/EmptyCharacterClass.ql
983
ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql
84+
ql/javascript/ql/src/RegExp/UnboundBackref.ql
85+
ql/javascript/ql/src/RegExp/UnmatchableCaret.ql
86+
ql/javascript/ql/src/RegExp/UnmatchableDollar.ql
87+
ql/javascript/ql/src/Statements/DanglingElse.ql
88+
ql/javascript/ql/src/Statements/IgnoreArrayResult.ql
89+
ql/javascript/ql/src/Statements/InconsistentLoopOrientation.ql
90+
ql/javascript/ql/src/Statements/LabelInCase.ql
91+
ql/javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql
92+
ql/javascript/ql/src/Statements/ReturnAssignsLocal.ql
93+
ql/javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
94+
ql/javascript/ql/src/Statements/UnreachableStatement.ql
95+
ql/javascript/ql/src/Statements/UseOfReturnlessFunction.ql
96+
ql/javascript/ql/src/Statements/UselessComparisonTest.ql
97+
ql/javascript/ql/src/Statements/UselessConditional.ql
98+
ql/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql

‎javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected

Lines changed: 89 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,98 @@
1+
ql/javascript/ql/src/AngularJS/DependencyMismatch.ql
2+
ql/javascript/ql/src/AngularJS/DuplicateDependency.ql
3+
ql/javascript/ql/src/AngularJS/IncompatibleService.ql
4+
ql/javascript/ql/src/AngularJS/MissingExplicitInjection.ql
5+
ql/javascript/ql/src/AngularJS/RepeatedInjection.ql
6+
ql/javascript/ql/src/AngularJS/UseNgSrc.ql
7+
ql/javascript/ql/src/DOM/DuplicateAttributes.ql
8+
ql/javascript/ql/src/DOM/MalformedIdAttribute.ql
9+
ql/javascript/ql/src/DOM/PseudoEval.ql
10+
ql/javascript/ql/src/Declarations/ArgumentsRedefined.ql
11+
ql/javascript/ql/src/Declarations/AssignmentToConst.ql
12+
ql/javascript/ql/src/Declarations/ClobberingVarInit.ql
13+
ql/javascript/ql/src/Declarations/ConflictingFunctions.ql
14+
ql/javascript/ql/src/Declarations/DeadStoreOfLocal.ql
15+
ql/javascript/ql/src/Declarations/DeadStoreOfProperty.ql
16+
ql/javascript/ql/src/Declarations/DeclBeforeUse.ql
17+
ql/javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql
18+
ql/javascript/ql/src/Declarations/DuplicateVarDecl.ql
119
ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql
20+
ql/javascript/ql/src/Declarations/MissingThisQualifier.ql
21+
ql/javascript/ql/src/Declarations/MissingVarDecl.ql
22+
ql/javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql
223
ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql
24+
ql/javascript/ql/src/Declarations/TemporalDeadZone.ql
25+
ql/javascript/ql/src/Declarations/UniqueParameterNames.ql
26+
ql/javascript/ql/src/Declarations/UniquePropertyNames.ql
27+
ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql
28+
ql/javascript/ql/src/Declarations/UnusedVariable.ql
29+
ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql
30+
ql/javascript/ql/src/Expressions/DuplicateCondition.ql
31+
ql/javascript/ql/src/Expressions/DuplicateProperty.ql
32+
ql/javascript/ql/src/Expressions/DuplicateSwitchCase.ql
333
ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql
34+
ql/javascript/ql/src/Expressions/HeterogeneousComparison.ql
35+
ql/javascript/ql/src/Expressions/ImplicitOperandConversion.ql
436
ql/javascript/ql/src/Expressions/MissingAwait.ql
37+
ql/javascript/ql/src/Expressions/MissingDotLengthInComparison.ql
38+
ql/javascript/ql/src/Expressions/MissingSpaceInAppend.ql
39+
ql/javascript/ql/src/Expressions/MisspelledVariableName.ql
40+
ql/javascript/ql/src/Expressions/RedundantExpression.ql
41+
ql/javascript/ql/src/Expressions/SelfAssignment.ql
42+
ql/javascript/ql/src/Expressions/ShiftOutOfRange.ql
43+
ql/javascript/ql/src/Expressions/StringInsteadOfRegex.ql
44+
ql/javascript/ql/src/Expressions/SuspiciousInvocation.ql
45+
ql/javascript/ql/src/Expressions/SuspiciousPropAccess.ql
46+
ql/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql
47+
ql/javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql
48+
ql/javascript/ql/src/Expressions/UnknownDirective.ql
49+
ql/javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql
50+
ql/javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql
51+
ql/javascript/ql/src/LanguageFeatures/BadTypeof.ql
52+
ql/javascript/ql/src/LanguageFeatures/ConditionalComments.ql
53+
ql/javascript/ql/src/LanguageFeatures/DeleteVar.ql
54+
ql/javascript/ql/src/LanguageFeatures/ExpressionClosures.ql
55+
ql/javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql
56+
ql/javascript/ql/src/LanguageFeatures/IllegalInvocation.ql
57+
ql/javascript/ql/src/LanguageFeatures/InconsistentNew.ql
58+
ql/javascript/ql/src/LanguageFeatures/InvalidPrototype.ql
59+
ql/javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql
60+
ql/javascript/ql/src/LanguageFeatures/NonLinearPattern.ql
61+
ql/javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql
62+
ql/javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql
63+
ql/javascript/ql/src/LanguageFeatures/SetterReturn.ql
564
ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
65+
ql/javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql
66+
ql/javascript/ql/src/LanguageFeatures/SyntaxError.ql
667
ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql
68+
ql/javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql
69+
ql/javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql
70+
ql/javascript/ql/src/LanguageFeatures/WithStatement.ql
71+
ql/javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql
72+
ql/javascript/ql/src/NodeJS/InvalidExport.ql
73+
ql/javascript/ql/src/NodeJS/MissingExports.ql
774
ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql
75+
ql/javascript/ql/src/React/DirectStateMutation.ql
76+
ql/javascript/ql/src/React/InconsistentStateUpdate.ql
77+
ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql
78+
ql/javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql
79+
ql/javascript/ql/src/RegExp/BackrefBeforeGroup.ql
80+
ql/javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql
881
ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql
82+
ql/javascript/ql/src/RegExp/EmptyCharacterClass.ql
983
ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql
84+
ql/javascript/ql/src/RegExp/UnboundBackref.ql
85+
ql/javascript/ql/src/RegExp/UnmatchableCaret.ql
86+
ql/javascript/ql/src/RegExp/UnmatchableDollar.ql
87+
ql/javascript/ql/src/Statements/DanglingElse.ql
88+
ql/javascript/ql/src/Statements/IgnoreArrayResult.ql
89+
ql/javascript/ql/src/Statements/InconsistentLoopOrientation.ql
90+
ql/javascript/ql/src/Statements/LabelInCase.ql
91+
ql/javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql
92+
ql/javascript/ql/src/Statements/ReturnAssignsLocal.ql
93+
ql/javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
94+
ql/javascript/ql/src/Statements/UnreachableStatement.ql
95+
ql/javascript/ql/src/Statements/UseOfReturnlessFunction.ql
96+
ql/javascript/ql/src/Statements/UselessComparisonTest.ql
97+
ql/javascript/ql/src/Statements/UselessConditional.ql
98+
ql/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql

‎javascript/ql/src/AngularJS/DependencyMismatch.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@
77
* @problem.severity warning
88
* @precision very-high
99
* @id js/angular/dependency-injection-mismatch
10-
* @tags correctness
11-
* maintainability
10+
* @tags quality
11+
* reliability
12+
* correctness
1213
* frameworks/angularjs
1314
*/
1415

‎javascript/ql/src/AngularJS/DuplicateDependency.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
* @problem.severity warning
66
* @precision very-high
77
* @id js/angular/duplicate-dependency
8-
* @tags maintainability
8+
* @tags quality
9+
* maintainability
10+
* readability
911
* frameworks/angularjs
1012
*/
1113

‎javascript/ql/src/AngularJS/IncompatibleService.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
* @problem.severity error
66
* @precision high
77
* @id js/angular/incompatible-service
8-
* @tags correctness
8+
* @tags quality
9+
* reliability
10+
* correctness
911
* frameworks/angularjs
1012
*/
1113

‎javascript/ql/src/AngularJS/MissingExplicitInjection.ql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@
66
* @problem.severity warning
77
* @precision high
88
* @id js/angular/missing-explicit-injection
9-
* @tags correctness
10-
* maintainability
9+
* @tags quality
10+
* reliability
11+
* correctness
1112
* frameworks/angularjs
1213
*/
1314

‎javascript/ql/src/AngularJS/RepeatedInjection.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
* @problem.severity warning
66
* @precision high
77
* @id js/angular/repeated-dependency-injection
8-
* @tags maintainability
8+
* @tags quality
9+
* maintainability
10+
* readability
911
* frameworks/angularjs
1012
*/
1113

‎javascript/ql/src/AngularJS/UseNgSrc.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
* @problem.severity warning
88
* @precision very-high
99
* @id js/angular/expression-in-url-attribute
10-
* @tags maintainability
10+
* @tags quality
11+
* reliability
12+
* correctness
1113
* frameworks/angularjs
1214
*/
1315

‎javascript/ql/src/DOM/DuplicateAttributes.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
* @kind problem
66
* @problem.severity warning
77
* @id js/duplicate-html-attribute
8-
* @tags maintainability
8+
* @tags quality
9+
* maintainability
910
* readability
1011
* @precision very-high
1112
*/

‎javascript/ql/src/DOM/MalformedIdAttribute.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
* @kind problem
66
* @problem.severity warning
77
* @id js/malformed-html-id
8-
* @tags maintainability
8+
* @tags quality
9+
* reliability
910
* correctness
1011
* external/cwe/cwe-758
1112
* @precision very-high

0 commit comments

Comments
 (0)