Création de compte candidat : gestion des permissions #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenKorr
added
the
no-changelog
EwenKorr
force-pushed
the
ewen/get-or-create-permissions
branch
from
75cf9c4 to
4311bf9
Compare
1 task
xavfernandez
approved these changes
Jan 21, 2025
… seekers Explicitely prevent labor inspectors and itou staff from accessing the start view that initializes the session for job seekers creation. Move the corresponding tests from `apply` to `job_seekers_views` and adapt them. Only add tests for the Update start view, the code was already explicit (`can_view_personal_information`)
They belong to job_seekers_views now.
In job_seekers_views, GetOrCreate views come in two different flavors: - CheckNIRForJobSeeker, only for job seekers - CheckNIRForSender, SearchByEmailForSender etc, for senders/hire It is virtually impossible to be on the wrong flavor by mistake, because of the session system: we check the user kind and create a session that can be used on that flavor only. However we keep a safety rail: a 403 error when a user kind does not match the current flavor.
EwenKorr
force-pushed
the
ewen/get-or-create-permissions
branch
from
4311bf9 to
6fe652e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
En voulant nettoyer/migrer les tests de création de compte candidat depuis
applyversjob_seekers_views, je me suis rendu compte qu'il manquait une vérification de permission/userkind : les inspecteurs du travail et le staff Itou ne devraient pas être capables de créer de compte candidat (commit n°2).J'ai également un peu simplifié ce qu'il se passe quand un utilisateur d'un certain type arrive sur le tunnel d'un autre type (par exemple, un
job_seekersurCheckNIRForSenderou un employeur surCheckNIRForJobSeeker).En pratique, ceci ne devrait jamais arriver, pour deux raisons :
logger.infoqui relève quand une redirection se produit (https://github.com/gip-inclusion/les-emplois/blob/master/itou/www/job_seekers_views/views.py#L305, https://github.com/gip-inclusion/les-emplois/blob/master/itou/www/job_seekers_views/views.py#L326), le logger n'a jamais rien donnésession_kindne correspond pas à l'action qu'on essaie de faireMais au cas où, je laisse un garde-fou : une erreur 403 quand on accède au mauvais type (commit n°4).
À voir si on supprime ce garde-fou également.