Création de compte candidat : léger refactoring de gestion de la session #5436
+50
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenKorr
added
the
no-changelog
EwenKorr
changed the title
EwenKorr
force-pushed
the
ewen/session-kind-mixin
branch
3 times, most recently
from
2ce805a to
262dd1d
Compare
EwenKorr
force-pushed
the
ewen/session-kind-mixin
branch
from
262dd1d to
b3fb316
Compare
itou/templates/job_seekers_views/create_or_update_job_seeker/step_1.html
Outdated
Show resolved
Hide resolved
itou/www/job_seekers_views/views.py
Outdated
| @@ -220,27 +220,47 @@ def get(self, request, *args, **kwargs): | |||
| return HttpResponseRedirect(reverse(view_name, kwargs={"session_uuid": self.job_seeker_session.name})) | |||
|
|
|||
|
|
|||
| class JobSeekerBaseView(TemplateView): | |||
| class ExpectedJobSeekerKindMixin(TemplateView): | |||
There was a problem hiding this comment.
Suggested change
| class ExpectedJobSeekerKindMixin(TemplateView): | |
| class ExpectedJobSeekerSessionMixin(TemplateView): |
et on pourra même éventuellement enlever le JobSeeker dans le futur en renommant self.job_seeker_session en self.session_namespace
There was a problem hiding this comment.
Oui 👍
Un pas de plus vers une généralisation ?
EwenKorr
force-pushed
the
ewen/session-kind-mixin
branch
2 times, most recently
from
d32d7b4 to
e60c507
Compare
xavfernandez
approved these changes
Jan 23, 2025
- ExpectedJobSeekerSessionMixin: to get the session and check that it was created to perform the action we're doing - JobSeekerBaseView: now uses this mixin - Update views: also use this mixin, instead of inheriting JobSeekerBaseView
It was facultative for the sake of deployment.
EwenKorr
force-pushed
the
ewen/session-kind-mixin
branch
from
e60c507 to
4659f66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Mieux séparer quelle classe fait quoi, dans
job_seekers_views.🍰 Comment ?
La session est maintenant gérée par
ExpectedJobSeekerSessionMixin: elle récupère une session et vérifie que la session a bien été créée pour effectuer l'action en cours.Cette mixin est héritée par
JobSeekerBaseView, qui ajoute la gestion des tunnels (is_gps,company, etc).Enfin,
UpdateJobSeekerBaseViewhérite de la mixin et non plus deJobSeekerBaseView, car ces vues sont indépendantes deis_gps,companyetc.🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran