Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize CUDA CMake setup #1368

Merged
merged 14 commits into from
Aug 10, 2023
Merged

Modernize CUDA CMake setup #1368

merged 14 commits into from
Aug 10, 2023

Commits on Aug 7, 2023

  1. modernize CUDA setup

    @upsj
    upsj committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    cb89d7b View commit details
    Browse the repository at this point in the history

  2. find CUDAToolkit in installed ginkgo

    @upsj
    upsj committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e433610 View commit details
    Browse the repository at this point in the history

  3. throw error on insufficient CMake version

    @upsj
    upsj committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b1d5cb1 View commit details
    Browse the repository at this point in the history

  4. fix version requirement

    @upsj
    upsj committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6bb2b7c View commit details
    Browse the repository at this point in the history

  5. set CUDA host compiler before enabling language 

    Otherwise, the host compiler might not be used
    @upsj
    upsj committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ff1657f View commit details
    Browse the repository at this point in the history

  6. review updates 

    - Set host compiler via environment variable
- update CMake version requirement with CUDA to 3.18
- remove RPATH for CUDA

Co-authored-by: Marcel Koch <[email protected]>
    @upsj @MarcelKoch
    upsj and MarcelKoch committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4ba9c82 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. fix test names

    @upsj
    upsj committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d97f479 View commit details
    Browse the repository at this point in the history

  2. set CMAKE_CUDA_ARCHITECTURES from CAS

    @upsj
    upsj committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    100da3f View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. update container names

    @upsj
    upsj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e8da815 View commit details
    Browse the repository at this point in the history

  2. remove duplicate pipeline

    @upsj
    upsj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6f7c389 View commit details
    Browse the repository at this point in the history

  3. adapt remaining CMake flags

    @upsj
    upsj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    020970a View commit details
    Browse the repository at this point in the history

  4. review updates 

    - Only detect available GPUs if requested
- Remove unnecessary include paths
- Remove unnecessary config variables

Co-authored-by: Marcel Koch <[email protected]>
Co-authored-by: Terry Cojean <[email protected]>
    @upsj @MarcelKoch @tcojean
    3 people committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ee9aead View commit details
    Browse the repository at this point in the history

  5. temporarily disable PAPI

    @upsj
    upsj committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    8056b50 View commit details
    Browse the repository at this point in the history

  6. review updates 

    - Bump CMake requirement in example
- Add NVHPC CMake requirements to README

Co-authored-by: Yuhsiang M. Tsai <[email protected]>
    @upsj @yhmtsai
    upsj and yhmtsai committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    5dbf0ff View commit details
    Browse the repository at this point in the history