Modernize CUDA CMake setup #1368

upsj · 2023-07-11T11:59:34Z

Extracted out of #1334, this contains the following changes

Set the minimum requirement for CMake to 3.16 (which is the version shipped with Ubuntu 20.04 LTS)
Set the minimum requirement for CUDA builds to CMake 3.18 to enable usage of the FindCUDAToolkit module
Use FindCUDAToolkit instead of manually searching for the CUDA runtime, cuBLAS, cuSPARSE, cuRAND and cuFFT
Set CMAKE_CUDA_ARCHITECTURES via CAS
Set C++ and CUDA (host) compiler via environment variables

cuda/CMakeLists.txt

yhmtsai · 2023-07-11T12:40:25Z

It seems not to solve the problem on Perlmutter? and CudaSelector needs to be 3.24 to get the auto device detection.
the error is

CMake Error at cuda/CMakeLists.txt:2 (add_library):
  Target "ginkgo_cuda" links to target "CUDA::cublas" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


CMake Error at cuda/CMakeLists.txt:2 (add_library):
  Target "ginkgo_cuda" links to target "CUDA::cusparse" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Error at cuda/CMakeLists.txt:2 (add_library):
  Target "ginkgo_cuda" links to target "CUDA::curand" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?


CMake Error at cuda/CMakeLists.txt:2 (add_library):
  Target "ginkgo_cuda" links to target "CUDA::cufft" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?

like the issue's post.

upsj · 2023-07-12T08:59:32Z

@yhmtsai That's a CMake issue then, maybe related to Kitware/CMake#348?

yhmtsai · 2023-07-13T08:50:02Z

they fix it in cmake 3.22 from https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6591
I try the Perlmutter cmake 3.22.0, and it can find the math_libs.

yhmtsai

We also need to add the error and ask to use cmake >= 3.22 when they do not find the target with nvhpc cuda.
For the findCUDAToolkit, we can not have workaround for nvhpc with cmake < 3.22

yhmtsai · 2023-07-20T10:03:16Z

cmake/GinkgoConfig.cmake.in

@@ -174,6 +170,7 @@ endif()
 # For details, see https://gitlab.kitware.com/cmake/cmake/issues/18614
 if((NOT GINKGO_BUILD_SHARED_LIBS) AND GINKGO_BUILD_CUDA)
    enable_language(CUDA)
+    find_package(CUDAToolkit REQUIRED)
    find_package(NVTX REQUIRED)


should we also use CUDA::nvToolsExt when cmake < 3.25 and CUDA::nvtx3 when cmake >= 3.25?

I think as long as we need to support both versions (which require different includes), it's easier to use the existing FindNVTX module.

MarcelKoch

I like the CMake changes, perhaps we could also go a bit higher as mentioned in the comments. Perhaps it makes sense to separate the changes from cmake and removing cuda 9.2

.gitlab-ci.yml

.gitlab/image.yml

README.md

benchmark/CMakeLists.txt

cmake/GinkgoConfig.cmake.in

cuda/CMakeLists.txt

cuda/get_info.cmake

cuda/test/solver/CMakeLists.txt

Otherwise, the host compiler might not be used

- Set host compiler via environment variable - update CMake version requirement with CUDA to 3.18 - remove RPATH for CUDA Co-authored-by: Marcel Koch <[email protected]>

MarcelKoch

LGTM, only few small nits.

benchmark/CMakeLists.txt

cmake/GinkgoConfig.cmake.in

cmake/cuda.cmake

cmake/Modules/CudaArchitectureSelector.cmake

pratikvn

LGTM!

tcojean

LGTM

.gitlab/scripts.yml

- Only detect available GPUs if requested - Remove unnecessary include paths - Remove unnecessary config variables Co-authored-by: Marcel Koch <[email protected]> Co-authored-by: Terry Cojean <[email protected]>

examples/custom-matrix-format/CMakeLists.txt

test/test_install/CMakeLists.txt

cuda/CMakeLists.txt

.gitlab-ci.yml

cuda/test/solver/CMakeLists.txt

examples/custom-matrix-format/CMakeLists.txt

- Bump CMake requirement in example - Add NVHPC CMake requirements to README Co-authored-by: Yuhsiang M. Tsai <[email protected]>

sonarcloud · 2023-08-11T00:40:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Release 1.7.0 to master The Ginkgo team is proud to announce the new Ginkgo minor release 1.7.0. This release brings new features such as: - Complete GPU-resident sparse direct solvers feature set and interfaces, - Improved Cholesky factorization performance, - A new MC64 reordering, - Batched iterative solver support with the BiCGSTAB solver with batched Dense and ELL matrix types, - MPI support for the SYCL backend, - Improved ParILU(T)/ParIC(T) preconditioner convergence, and more! If you face an issue, please first check our [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues) and the [open issues list](https://github.com/ginkgo-project/ginkgo/issues) and if you do not find a solution, feel free to [open a new issue](https://github.com/ginkgo-project/ginkgo/issues/new/choose) or ask a question using the [github discussions](https://github.com/ginkgo-project/ginkgo/discussions). Supported systems and requirements: + For all platforms, CMake 3.16+ + C++14 compliant compiler + Linux and macOS + GCC: 5.5+ + clang: 3.9+ + Intel compiler: 2019+ + Apple Clang: 14.0 is tested. Earlier versions might also work. + NVHPC: 22.7+ + Cray Compiler: 14.0.1+ + CUDA module: CMake 3.18+, and CUDA 10.1+ or NVHPC 22.7+ + HIP module: ROCm 4.5+ + DPC++ module: Intel oneAPI 2022.1+ with oneMKL and oneDPL. Set the CXX compiler to `dpcpp` or `icpx`. + MPI: standard version 3.1+, ideally GPU Aware, for best performance + Windows + MinGW: GCC 5.5+ + Microsoft Visual Studio: VS 2019+ + CUDA module: CUDA 10.1+, Microsoft Visual Studio + OpenMP module: MinGW. ### Version support changes + CUDA 9.2 is no longer supported and 10.0 is untested [#1382](#1382) + Ginkgo now requires CMake version 3.16 (and 3.18 for CUDA) [#1368](#1368) ### Interface changes + `const` Factory parameters can no longer be modified through `with_*` functions, as this breaks const-correctness [#1336](#1336) [#1439](#1439) ### New Deprecations + The `device_reset` parameter of CUDA and HIP executors no longer has an effect, and its `allocation_mode` parameters have been deprecated in favor of the `Allocator` interface. [#1315](#1315) + The CMake parameter `GINKGO_BUILD_DPCPP` has been deprecated in favor of `GINKGO_BUILD_SYCL`. [#1350](#1350) + The `gko::reorder::Rcm` interface has been deprecated in favor of `gko::experimental::reorder::Rcm` based on `Permutation`. [#1418](#1418) + The Permutation class' `permute_mask` functionality. [#1415](#1415) + Multiple functions with typos (`set_complex_subpsace()`, range functions such as `conj_operaton` etc). [#1348](#1348) ### Summary of previous deprecations + `gko::lend()` is not necessary anymore. + The classes `RelativeResidualNorm` and `AbsoluteResidualNorm` are deprecated in favor of `ResidualNorm`. + The class `AmgxPgm` is deprecated in favor of `Pgm`. + Default constructors for the CSR `load_balance` and `automatical` strategies + The PolymorphicObject's move-semantic `copy_from` variant + The templated `SolverBase` class. + The class `MachineTopology` is deprecated in favor of `machine_topology`. + Logger constructors and create functions with the `executor` parameter. + The virtual, protected, Dense functions `compute_norm1_impl`, `add_scaled_impl`, etc. + Logger events for solvers and criterion without the additional `implicit_tau_sq` parameter. + The global `gko::solver::default_krylov_dim`, use instead `gko::solver::gmres_default_krylov_dim`. ### Added features + Adds a batch::BatchLinOp class that forms a base class for batched linear operators such as batched matrix formats, solver and preconditioners [#1379](#1379) + Adds a batch::MultiVector class that enables operations such as dot, norm, scale on batched vectors [#1371](#1371) + Adds a batch::Dense matrix format that stores batched dense matrices and provides gemv operations for these dense matrices. [#1413](#1413) + Adds a batch::Ell matrix format that stores batched Ell matrices and provides spmv operations for these batched Ell matrices. [#1416](#1416) [#1437](#1437) + Add a batch::Bicgstab solver (class, core, and reference kernels) that enables iterative solution of batched linear systems [#1438](#1438). + Add device kernels (CUDA, HIP, and DPCPP) for batch::Bicgstab solver. [#1443](#1443). + New MC64 reordering algorithm which optimizes the diagonal product or sum of a matrix by permuting the rows, and computes additional scaling factors for equilibriation [#1120](#1120) + New interface for (non-symmetric) permutation and scaled permutation of Dense and Csr matrices [#1415](#1415) + LU and Cholesky Factorizations can now be separated into their factors [#1432](#1432) + New symbolic LU factorization algorithm that is optimized for matrices with an almost-symmetric sparsity pattern [#1445](#1445) + Sorting kernels for SparsityCsr on all backends [#1343](#1343) + Allow passing pre-generated local solver as factory parameter for the distributed Schwarz preconditioner [#1426](#1426) + Add DPCPP kernels for Partition [#1034](#1034), and CSR's `check_diagonal_entries` and `add_scaled_identity` functionality [#1436](#1436) + Adds a helper function to create a partition based on either local sizes, or local ranges [#1227](#1227) + Add function to compute arithmetic mean of dense and distributed vectors [#1275](#1275) + Adds `icpx` compiler supports [#1350](#1350) + All backends can be built simultaneously [#1333](#1333) + Emits a CMake warning in downstream projects that use different compilers than the installed Ginkgo [#1372](#1372) + Reordering algorithms in sparse_blas benchmark [#1354](#1354) + Benchmarks gained an `-allocator` parameter to specify device allocators [#1385](#1385) + Benchmarks gained an `-input_matrix` parameter that initializes the input JSON based on the filename [#1387](#1387) + Benchmark inputs can now be reordered as a preprocessing step [#1408](#1408) ### Improvements + Significantly improve Cholesky factorization performance [#1366](#1366) + Improve parallel build performance [#1378](#1378) + Allow constrained parallel test execution using CTest resources [#1373](#1373) + Use arithmetic type more inside mixed precision ELL [#1414](#1414) + Most factory parameters of factory type no longer need to be constructed explicitly via `.on(exec)` [#1336](#1336) [#1439](#1439) + Improve ParILU(T)/ParIC(T) convergence by using more appropriate atomic operations [#1434](#1434) ### Fixes + Fix an over-allocation for OpenMP reductions [#1369](#1369) + Fix DPCPP's common-kernel reduction for empty input sizes [#1362](#1362) + Fix several typos in the API and documentation [#1348](#1348) + Fix inconsistent `Threads` between generations [#1388](#1388) + Fix benchmark median condition [#1398](#1398) + Fix HIP 5.6.0 compilation [#1411](#1411) + Fix missing destruction of rand_generator from cuda/hip [#1417](#1417) + Fix PAPI logger destruction order [#1419](#1419) + Fix TAU logger compilation [#1422](#1422) + Fix relative criterion to not iterate if the residual is already zero [#1079](#1079) + Fix memory_order invocations with C++20 changes [#1402](#1402) + Fix `check_diagonal_entries_exist` report correctly when only missing diagonal value in the last rows. [#1440](#1440) + Fix checking OpenMPI version in cross-compilation settings [#1446](#1446) + Fix false-positive deprecation warnings in Ginkgo, especially for the old Rcm (it doesn't emit deprecation warnings anymore as a result but is still considered deprecated) [#1444](#1444) ### Related PR: #1451

Release 1.7.0 to develop The Ginkgo team is proud to announce the new Ginkgo minor release 1.7.0. This release brings new features such as: - Complete GPU-resident sparse direct solvers feature set and interfaces, - Improved Cholesky factorization performance, - A new MC64 reordering, - Batched iterative solver support with the BiCGSTAB solver with batched Dense and ELL matrix types, - MPI support for the SYCL backend, - Improved ParILU(T)/ParIC(T) preconditioner convergence, and more! If you face an issue, please first check our [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues) and the [open issues list](https://github.com/ginkgo-project/ginkgo/issues) and if you do not find a solution, feel free to [open a new issue](https://github.com/ginkgo-project/ginkgo/issues/new/choose) or ask a question using the [github discussions](https://github.com/ginkgo-project/ginkgo/discussions). Supported systems and requirements: + For all platforms, CMake 3.16+ + C++14 compliant compiler + Linux and macOS + GCC: 5.5+ + clang: 3.9+ + Intel compiler: 2019+ + Apple Clang: 14.0 is tested. Earlier versions might also work. + NVHPC: 22.7+ + Cray Compiler: 14.0.1+ + CUDA module: CMake 3.18+, and CUDA 10.1+ or NVHPC 22.7+ + HIP module: ROCm 4.5+ + DPC++ module: Intel oneAPI 2022.1+ with oneMKL and oneDPL. Set the CXX compiler to `dpcpp` or `icpx`. + MPI: standard version 3.1+, ideally GPU Aware, for best performance + Windows + MinGW: GCC 5.5+ + Microsoft Visual Studio: VS 2019+ + CUDA module: CUDA 10.1+, Microsoft Visual Studio + OpenMP module: MinGW. ### Version support changes + CUDA 9.2 is no longer supported and 10.0 is untested [#1382](#1382) + Ginkgo now requires CMake version 3.16 (and 3.18 for CUDA) [#1368](#1368) ### Interface changes + `const` Factory parameters can no longer be modified through `with_*` functions, as this breaks const-correctness [#1336](#1336) [#1439](#1439) ### New Deprecations + The `device_reset` parameter of CUDA and HIP executors no longer has an effect, and its `allocation_mode` parameters have been deprecated in favor of the `Allocator` interface. [#1315](#1315) + The CMake parameter `GINKGO_BUILD_DPCPP` has been deprecated in favor of `GINKGO_BUILD_SYCL`. [#1350](#1350) + The `gko::reorder::Rcm` interface has been deprecated in favor of `gko::experimental::reorder::Rcm` based on `Permutation`. [#1418](#1418) + The Permutation class' `permute_mask` functionality. [#1415](#1415) + Multiple functions with typos (`set_complex_subpsace()`, range functions such as `conj_operaton` etc). [#1348](#1348) ### Summary of previous deprecations + `gko::lend()` is not necessary anymore. + The classes `RelativeResidualNorm` and `AbsoluteResidualNorm` are deprecated in favor of `ResidualNorm`. + The class `AmgxPgm` is deprecated in favor of `Pgm`. + Default constructors for the CSR `load_balance` and `automatical` strategies + The PolymorphicObject's move-semantic `copy_from` variant + The templated `SolverBase` class. + The class `MachineTopology` is deprecated in favor of `machine_topology`. + Logger constructors and create functions with the `executor` parameter. + The virtual, protected, Dense functions `compute_norm1_impl`, `add_scaled_impl`, etc. + Logger events for solvers and criterion without the additional `implicit_tau_sq` parameter. + The global `gko::solver::default_krylov_dim`, use instead `gko::solver::gmres_default_krylov_dim`. ### Added features + Adds a batch::BatchLinOp class that forms a base class for batched linear operators such as batched matrix formats, solver and preconditioners [#1379](#1379) + Adds a batch::MultiVector class that enables operations such as dot, norm, scale on batched vectors [#1371](#1371) + Adds a batch::Dense matrix format that stores batched dense matrices and provides gemv operations for these dense matrices. [#1413](#1413) + Adds a batch::Ell matrix format that stores batched Ell matrices and provides spmv operations for these batched Ell matrices. [#1416](#1416) [#1437](#1437) + Add a batch::Bicgstab solver (class, core, and reference kernels) that enables iterative solution of batched linear systems [#1438](#1438). + Add device kernels (CUDA, HIP, and DPCPP) for batch::Bicgstab solver. [#1443](#1443). + New MC64 reordering algorithm which optimizes the diagonal product or sum of a matrix by permuting the rows, and computes additional scaling factors for equilibriation [#1120](#1120) + New interface for (non-symmetric) permutation and scaled permutation of Dense and Csr matrices [#1415](#1415) + LU and Cholesky Factorizations can now be separated into their factors [#1432](#1432) + New symbolic LU factorization algorithm that is optimized for matrices with an almost-symmetric sparsity pattern [#1445](#1445) + Sorting kernels for SparsityCsr on all backends [#1343](#1343) + Allow passing pre-generated local solver as factory parameter for the distributed Schwarz preconditioner [#1426](#1426) + Add DPCPP kernels for Partition [#1034](#1034), and CSR's `check_diagonal_entries` and `add_scaled_identity` functionality [#1436](#1436) + Adds a helper function to create a partition based on either local sizes, or local ranges [#1227](#1227) + Add function to compute arithmetic mean of dense and distributed vectors [#1275](#1275) + Adds `icpx` compiler supports [#1350](#1350) + All backends can be built simultaneously [#1333](#1333) + Emits a CMake warning in downstream projects that use different compilers than the installed Ginkgo [#1372](#1372) + Reordering algorithms in sparse_blas benchmark [#1354](#1354) + Benchmarks gained an `-allocator` parameter to specify device allocators [#1385](#1385) + Benchmarks gained an `-input_matrix` parameter that initializes the input JSON based on the filename [#1387](#1387) + Benchmark inputs can now be reordered as a preprocessing step [#1408](#1408) ### Improvements + Significantly improve Cholesky factorization performance [#1366](#1366) + Improve parallel build performance [#1378](#1378) + Allow constrained parallel test execution using CTest resources [#1373](#1373) + Use arithmetic type more inside mixed precision ELL [#1414](#1414) + Most factory parameters of factory type no longer need to be constructed explicitly via `.on(exec)` [#1336](#1336) [#1439](#1439) + Improve ParILU(T)/ParIC(T) convergence by using more appropriate atomic operations [#1434](#1434) ### Fixes + Fix an over-allocation for OpenMP reductions [#1369](#1369) + Fix DPCPP's common-kernel reduction for empty input sizes [#1362](#1362) + Fix several typos in the API and documentation [#1348](#1348) + Fix inconsistent `Threads` between generations [#1388](#1388) + Fix benchmark median condition [#1398](#1398) + Fix HIP 5.6.0 compilation [#1411](#1411) + Fix missing destruction of rand_generator from cuda/hip [#1417](#1417) + Fix PAPI logger destruction order [#1419](#1419) + Fix TAU logger compilation [#1422](#1422) + Fix relative criterion to not iterate if the residual is already zero [#1079](#1079) + Fix memory_order invocations with C++20 changes [#1402](#1402) + Fix `check_diagonal_entries_exist` report correctly when only missing diagonal value in the last rows. [#1440](#1440) + Fix checking OpenMPI version in cross-compilation settings [#1446](#1446) + Fix false-positive deprecation warnings in Ginkgo, especially for the old Rcm (it doesn't emit deprecation warnings anymore as a result but is still considered deprecated) [#1444](#1444) ### Related PR: #1454

upsj self-assigned this Jul 11, 2023

upsj added the 1:ST:ready-for-review This PR is ready for review label Jul 11, 2023

upsj requested review from a team July 11, 2023 11:59

MarcelKoch reviewed Jul 11, 2023

View reviewed changes

cuda/CMakeLists.txt Outdated Show resolved Hide resolved

upsj force-pushed the cuda_cmake_modernize branch from 3b2142f to 9da001c Compare July 17, 2023 08:59

upsj mentioned this pull request Jul 18, 2023

Building Ginkgo on Perlmutter #1367

Closed

yhmtsai reviewed Jul 20, 2023

View reviewed changes

MarcelKoch mentioned this pull request Jul 21, 2023

Fix missing MPI in custom-matrix-format example #1370

Closed

upsj mentioned this pull request Jul 25, 2023

Check downstream compilers #1372

Merged

upsj force-pushed the cuda_cmake_modernize branch 2 times, most recently from df39d7c to dd2c023 Compare July 27, 2023 15:04

MarcelKoch mentioned this pull request Aug 3, 2023

Enable CTest Resources #1373

Merged

MarcelKoch requested changes Aug 3, 2023

View reviewed changes

upsj mentioned this pull request Aug 7, 2023

Remove CUDA 9.2 support #1382

Merged

upsj added 3 commits August 7, 2023 15:38

modernize CUDA setup

cb89d7b

find CUDAToolkit in installed ginkgo

e433610

throw error on insufficient CMake version

b1d5cb1

upsj and others added 3 commits August 7, 2023 15:38

fix version requirement

6bb2b7c

set CUDA host compiler before enabling language

ff1657f

Otherwise, the host compiler might not be used

review updates

4ba9c82

- Set host compiler via environment variable - update CMake version requirement with CUDA to 3.18 - remove RPATH for CUDA Co-authored-by: Marcel Koch <[email protected]>

upsj force-pushed the cuda_cmake_modernize branch from 916459d to 4ba9c82 Compare August 7, 2023 13:40

upsj added 2 commits August 9, 2023 20:51

fix test names

d97f479

set CMAKE_CUDA_ARCHITECTURES from CAS

100da3f

upsj requested a review from MarcelKoch August 10, 2023 07:54

update container names

e8da815

upsj force-pushed the cuda_cmake_modernize branch from 15deebc to e8da815 Compare August 10, 2023 08:07

upsj added the 1:ST:ready-for-review This PR is ready for review label Aug 10, 2023

MarcelKoch approved these changes Aug 10, 2023

View reviewed changes

benchmark/CMakeLists.txt Outdated Show resolved Hide resolved

cmake/GinkgoConfig.cmake.in Outdated Show resolved Hide resolved

cmake/cuda.cmake Outdated Show resolved Hide resolved

cmake/cuda.cmake Outdated Show resolved Hide resolved

upsj commented Aug 10, 2023

View reviewed changes

cmake/Modules/CudaArchitectureSelector.cmake Outdated Show resolved Hide resolved

pratikvn approved these changes Aug 10, 2023

View reviewed changes

tcojean approved these changes Aug 10, 2023

View reviewed changes

.gitlab/scripts.yml Outdated Show resolved Hide resolved

.gitlab/scripts.yml Outdated Show resolved Hide resolved

upsj added 2 commits August 10, 2023 13:48

remove duplicate pipeline

6f7c389

adapt remaining CMake flags

020970a

upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 10, 2023

upsj and others added 2 commits August 10, 2023 13:57

review updates

ee9aead

- Only detect available GPUs if requested - Remove unnecessary include paths - Remove unnecessary config variables Co-authored-by: Marcel Koch <[email protected]> Co-authored-by: Terry Cojean <[email protected]>

temporarily disable PAPI

8056b50

yhmtsai requested changes Aug 10, 2023

View reviewed changes

examples/custom-matrix-format/CMakeLists.txt Outdated Show resolved Hide resolved

examples/custom-matrix-format/CMakeLists.txt Show resolved Hide resolved

test/test_install/CMakeLists.txt Show resolved Hide resolved

cuda/CMakeLists.txt Show resolved Hide resolved

yhmtsai reviewed Aug 10, 2023

View reviewed changes

.gitlab-ci.yml Show resolved Hide resolved

cuda/test/solver/CMakeLists.txt Show resolved Hide resolved

examples/custom-matrix-format/CMakeLists.txt Show resolved Hide resolved

yhmtsai approved these changes Aug 10, 2023

View reviewed changes

review updates

5dbf0ff

- Bump CMake requirement in example - Add NVHPC CMake requirements to README Co-authored-by: Yuhsiang M. Tsai <[email protected]>

upsj merged commit 7b4134d into develop Aug 10, 2023
12 checks passed

upsj deleted the cuda_cmake_modernize branch August 10, 2023 16:55

tcojean mentioned this pull request Nov 6, 2023

Release 1.7.0 to master #1451

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize CUDA CMake setup #1368

Modernize CUDA CMake setup #1368

upsj commented Jul 11, 2023 •

edited

Loading

yhmtsai commented Jul 11, 2023

upsj commented Jul 12, 2023

yhmtsai commented Jul 13, 2023 •

edited

Loading

yhmtsai left a comment

yhmtsai Jul 20, 2023

upsj Jul 20, 2023

MarcelKoch left a comment

MarcelKoch left a comment

pratikvn left a comment

tcojean left a comment

sonarcloud bot commented Aug 11, 2023

Modernize CUDA CMake setup #1368

Modernize CUDA CMake setup #1368

Conversation

upsj commented Jul 11, 2023 • edited Loading

yhmtsai commented Jul 11, 2023

upsj commented Jul 12, 2023

yhmtsai commented Jul 13, 2023 • edited Loading

yhmtsai left a comment

Choose a reason for hiding this comment

yhmtsai Jul 20, 2023

Choose a reason for hiding this comment

upsj Jul 20, 2023

Choose a reason for hiding this comment

MarcelKoch left a comment

Choose a reason for hiding this comment

MarcelKoch left a comment

Choose a reason for hiding this comment

pratikvn left a comment

Choose a reason for hiding this comment

tcojean left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Aug 11, 2023

upsj commented Jul 11, 2023 •

edited

Loading

yhmtsai commented Jul 13, 2023 •

edited

Loading