Skip to content

Remove all the IPC #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2019
Merged

Remove all the IPC #358

merged 2 commits into from
Oct 26, 2019

Conversation

kvark
Copy link
Member

@kvark kvark commented Oct 25, 2019

Closes #146
Closes #22

We have decided to use Gecko IPC for Firefox. wgpu-remote will therefore provide all the Rust glue that Gecko needs for client and server:

  • initialization/termination of client/server
  • ID management for the client
  • pass encoding blobs

In Servo, we'd need to enable serde feature of wgpu-native and potentially roll out a different remoting crate that would establish a protocol based on ipc-channel, as we wanted originally.

@kvark kvark requested a review from grovesNL October 25, 2019 03:20
@kvark kvark mentioned this pull request Oct 25, 2019
Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark

Closes #146 
Closes #22

We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server:
  - initialization/termination of client/server
  - ID management for the client
  - pass encoding blobs

In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally.

Co-authored-by: Dzmitry Malyshau <[email protected]>
@grovesNL
Copy link
Collaborator

Looks like there is an error on one CI task:

/Applications/Xcode-9.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc   -isysroot /Applications/Xcode-9.4.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.9   -o CMakeFiles/remote.dir/main.c.o   -c /Users/travis/build/gfx-rs/wgpu/examples/remote/main.c

In file included from /Users/travis/build/gfx-rs/wgpu/examples/remote/main.c:1:

/Users/travis/build/gfx-rs/wgpu/examples/remote/./../../ffi/wgpu-remote.h:17:10: fatal error: 'cstdarg' file not found

#include <cstdarg>

         ^~~~~~~~~

1 error generated.

make[3]: *** [CMakeFiles/remote.dir/main.c.o] Error 1

make[2]: *** [CMakeFiles/remote.dir/all] Error 2

make[1]: *** [all] Error 2

make: *** [example-remote] Error 2

The command "if [[ $TRAVIS_RUST_VERSION == "nightly" ]] && [[ $TRAVIS_OS_NAME != "windows" ]]; then make VERBOSE=1; fi" exited with 2.

@bors
Copy link
Contributor

bors bot commented Oct 26, 2019

Build failed

@kvark
Copy link
Member Author

kvark commented Oct 26, 2019

bors r=grovesNL

bors bot added a commit that referenced this pull request Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark

Closes #146 
Closes #22

We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server:
  - initialization/termination of client/server
  - ID management for the client
  - pass encoding blobs

In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally.

Co-authored-by: Dzmitry Malyshau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2019

Canceled

@kvark
Copy link
Member Author

kvark commented Oct 26, 2019

bors r=grovesNL

bors bot added a commit that referenced this pull request Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark

Closes #146 
Closes #22

We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server:
  - initialization/termination of client/server
  - ID management for the client
  - pass encoding blobs

In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally.

Co-authored-by: Dzmitry Malyshau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2019

Build failed

@kvark
Copy link
Member Author

kvark commented Oct 26, 2019

bors retry

bors bot added a commit that referenced this pull request Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark

Closes #146 
Closes #22

We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server:
  - initialization/termination of client/server
  - ID management for the client
  - pass encoding blobs

In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally.

Co-authored-by: Dzmitry Malyshau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2019

Build failed

@kvark
Copy link
Member Author

kvark commented Oct 26, 2019

Argh, windows CI
bors retry

bors bot added a commit that referenced this pull request Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark

Closes #146 
Closes #22

We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server:
  - initialization/termination of client/server
  - ID management for the client
  - pass encoding blobs

In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally.

Co-authored-by: Dzmitry Malyshau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2019

Build succeeded

@bors bors bot merged commit 538c23b into gfx-rs:master Oct 26, 2019
@kvark kvark deleted the ipc branch October 26, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote: handle IPC on Windows Handle IPC descriptor serialization
2 participants