-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove all the IPC #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove all the IPC #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
grovesNL
approved these changes
Oct 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
bors bot
added a commit
that referenced
this pull request
Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark Closes #146 Closes #22 We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server: - initialization/termination of client/server - ID management for the client - pass encoding blobs In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally. Co-authored-by: Dzmitry Malyshau <[email protected]>
Looks like there is an error on one CI task:
|
Build failed |
bors r=grovesNL |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark Closes #146 Closes #22 We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server: - initialization/termination of client/server - ID management for the client - pass encoding blobs In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally. Co-authored-by: Dzmitry Malyshau <[email protected]>
Canceled |
bors r=grovesNL |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark Closes #146 Closes #22 We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server: - initialization/termination of client/server - ID management for the client - pass encoding blobs In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally. Co-authored-by: Dzmitry Malyshau <[email protected]>
Build failed |
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark Closes #146 Closes #22 We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server: - initialization/termination of client/server - ID management for the client - pass encoding blobs In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally. Co-authored-by: Dzmitry Malyshau <[email protected]>
Build failed |
Argh, windows CI |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2019
358: Remove all the IPC r=grovesNL a=kvark Closes #146 Closes #22 We have decided to use Gecko IPC for Firefox. `wgpu-remote` will therefore provide all the Rust glue that Gecko needs for client and server: - initialization/termination of client/server - ID management for the client - pass encoding blobs In Servo, we'd need to enable `serde` feature of `wgpu-native` and potentially roll out a different remoting crate that would establish a protocol based on `ipc-channel`, as we wanted originally. Co-authored-by: Dzmitry Malyshau <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146
Closes #22
We have decided to use Gecko IPC for Firefox.
wgpu-remote
will therefore provide all the Rust glue that Gecko needs for client and server:In Servo, we'd need to enable
serde
feature ofwgpu-native
and potentially roll out a different remoting crate that would establish a protocol based onipc-channel
, as we wanted originally.