Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxdg-basedir: Update to 1.2.3 #3568

Merged
merged 1 commit into from
Sep 13, 2024
Merged

libxdg-basedir: Update to 1.2.3 #3568

merged 1 commit into from
Sep 13, 2024

Conversation

EbonJaeger
Copy link
Member

Summary

  • Minor documentation fixes
  • Fix xdgZeroMemory fallback
  • Use strdup rather than malloc+strcpy
  • Fix overflow bug
  • Add homepage
  • Add monitoring.yml

Part of #3554

Signed-off-by: Evan Maddock [email protected]

Test Plan

Build radiotray-ng with this package.

Checklist

  • Package was built and tested against unstable

@TraceyC77
Copy link
Contributor

libxdg-basedir builds and installs, but I wasn't able to build radiotray-ng. I'm not sure if the failure is due to this update, it doesn't build with 1.2.0 either.

+ DESTDIR=/home/build/YPKG/root/radiotray-ng/install
+ ninja install -j16 -C solusBuildDir
ninja: Entering directory `solusBuildDir'
[1/2] Generating rtng_user_agent.hpp
FAILED: rtng_user_agent /home/build/YPKG/root/radiotray-ng/build/radiotray-ng-0.2.8/solusBuildDir/rtng_user_agent 
cd /home/build/YPKG/root/radiotray-ng/build/radiotray-ng-0.2.8 && /usr/bin/cmake -D PROJECT_SOURCE_DIR=/home/build/YPKG/root/radiotray-ng/build/radiotray-ng-0.2.8 -D CMAKE_RUNTIME_OUTPUT_DIRECTORY=/home/build/YPKG/root/radiotray-ng/build/radiotray-ng-0.2.8/solusBuildDir -D CMAKE_PROJECT_NAME=radiotray-ng -D PROJECT_VERSION=0.2.8 -D CMAKE_SYSTEM_NAME=Linux -D CMAKE_SYSTEM_PROCESSOR=x86_64 -P /home/build/YPKG/root/radiotray-ng/build/radiotray-ng-0.2.8/cmake/user-agent.cmake
CMake Error at cmake/user-agent.cmake:37 (configure_file):
  No such file or directory


ninja: build stopped: subcommand failed.
Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-install5rzw4ubm']' returned non-zero exit status 1.
[Build] install failed for radiotray-ng

@EbonJaeger
Copy link
Member Author

Weird. It builds fine for me, both in this branch, and on main.

**Summary**
- Minor documentation fixes
- Fix xdgZeroMemory fallback
- Use strdup rather than malloc+strcpy
- Fix overflow bug
- Add homepage
- Add `monitoring.yml`

Part of #3554

Signed-off-by: Evan Maddock <[email protected]>
@ReillyBrogan
Copy link
Contributor

Most likely that issue is caused by our fakeroot woes. I imagine @TraceyC77 doesn't have tmpfs enabled in solbuild which tends to work around it.

@ReillyBrogan ReillyBrogan merged commit c5b33e3 into main Sep 13, 2024
1 check passed
@ReillyBrogan ReillyBrogan deleted the libxdg-basedir-update branch September 13, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants