Skip to content

temp fix for ios log attach #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

NoCodeBugsFree
Copy link

No description provided.

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the underlying issue is this PR is addressing. Is the SDK not attaching logfiles? Did the logfiles move? Are we attaching the wrong ones? Could you clarify?
I missed the linked issue. My bad.

@bruno-garcia
Copy link
Member

@tustanivsky is this something we need to merge?

@tustanivsky
Copy link
Collaborator

@tustanivsky is this something we need to merge?

I've requested additional info in the linked ticket (#728). The changes suggested in this PR feel more like a workaround while the root cause of the issue remains unclear. Also, I wasn't able to reproduce it on my end so far which could mean it's something project/engine-specifc.

@EvoPulseGaming
Copy link

EvoPulseGaming commented Apr 9, 2025

In UE 5.5 what I found was that IOSPlatformFile checks for DoesCreatePublicFiles() when getting the path for the log.

In FIOSOutputDeviceFile::Serialize where the log is written to disk, it temporarily changes DoesCreatePublicFiles() to true via (&PlatformFile)->SetCreatePublicFiles(true).
It writes the log and then changes it back to whatever the value was before.

The problem with this, is there is no way for any other code to know about this. So when getting the file path to the log, you'll get the wrong path. (Library vs Documents folder)

@tustanivsky
Copy link
Collaborator

Superseded by #873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants