Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Bump timeout to 15 minutes, update cache behavior #682

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix(tests): Bump timeout to 15 minutes, update cache behavior #682

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29f9b6c
fix(tests): Bump timeout to 15 minutes, update cache behavior
tonyo Aug 1, 2023
2ca2f9f
Merge branch 'master' into tonyo/fix-timeout-tests-cache-1
cleptric Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ jobs:
key: ${{ runner.os }}-go-${{ matrix.go }}-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-${{ matrix.go }}-
${{ runner.os }}-go-
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this because it looks like when caches are partially cleared, there could be some weird failures when e.g. a Windows build with go1.20 takes the cache from go1.18

- name: Build
run: make build
- name: Vet
Expand All @@ -63,7 +62,7 @@ jobs:
uses: codecov/codecov-action@v3
with:
directory: .coverage
timeout-minutes: 10
timeout-minutes: 15
strategy:
matrix:
go: ["1.20", "1.19", "1.18"]
Expand Down
Loading