fix(tests): Bump timeout to 15 minutes, update cache behavior #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyo
commented
Aug 1, 2023
| @@ -40,7 +40,6 @@ jobs: | |||
| key: ${{ runner.os }}-go-${{ matrix.go }}-${{ hashFiles('**/go.sum') }} | |||
| restore-keys: | | |||
| ${{ runner.os }}-go-${{ matrix.go }}- | |||
| ${{ runner.os }}-go- | |||
There was a problem hiding this comment.
Removing this because it looks like when caches are partially cleared, there could be some weird failures when e.g. a Windows build with go1.20 takes the cache from go1.18
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 80.56% 80.56%
=======================================
Files 44 44
Lines 4460 4460
=======================================
Hits 3593 3593
Misses 736 736
Partials 131 131 ☔ View full report in Codecov by Sentry. |
cleptric
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows builds are now sometimes taking more than 10 minutes :/