test: more override config #5201
Conversation
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 84083f2 | 1233.36 ms | 1250.71 ms | 17.35 ms |
| bca2ddd | 1230.17 ms | 1255.33 ms | 25.16 ms |
| 5f32b69 | 1219.33 ms | 1245.29 ms | 25.97 ms |
| 3e116c4 | 1218.68 ms | 1238.50 ms | 19.82 ms |
| 32e3ad8 | 1228.22 ms | 1241.59 ms | 13.36 ms |
| c96b284 | 1224.82 ms | 1249.02 ms | 24.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 84083f2 | 23.76 KiB | 819.49 KiB | 795.73 KiB |
| bca2ddd | 23.76 KiB | 870.65 KiB | 846.89 KiB |
| 5f32b69 | 23.76 KiB | 870.58 KiB | 846.82 KiB |
| 3e116c4 | 23.76 KiB | 865.92 KiB | 842.16 KiB |
| 32e3ad8 | 23.76 KiB | 865.91 KiB | 842.15 KiB |
| c96b284 | 23.76 KiB | 870.58 KiB | 846.82 KiB |
Previous results on branch: armcknight/test/more-override-config
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ff4ed9 | 1211.19 ms | 1240.78 ms | 29.59 ms |
| 7694978 | 1236.12 ms | 1240.53 ms | 4.41 ms |
| 8eaa1b9 | 1216.39 ms | 1243.00 ms | 26.61 ms |
| a81288b | 1235.84 ms | 1250.69 ms | 14.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ff4ed9 | 23.76 KiB | 819.63 KiB | 795.87 KiB |
| 7694978 | 23.76 KiB | 870.85 KiB | 847.09 KiB |
| 8eaa1b9 | 23.76 KiB | 870.84 KiB | 847.08 KiB |
| a81288b | 23.76 KiB | 819.62 KiB | 795.86 KiB |
armcknight
force-pushed
the
armcknight/test/more-override-config
branch
from
02587a2 to
99bb9dd
Compare
armcknight
changed the base branch from
armcknight/test/restart-sdk-on-reconfig
to
armcknight/test/sample-app-debug-menu
| @@ -66,7 +66,7 @@ public class SentryReplayOptions: NSObject, SentryRedactOptions { | |||
| /** | |||
| * Used by Hybrid SDKs. | |||
| */ | |||
| static func fromName(_ name: String) -> SentryReplayOptions.SentryReplayQuality { | |||
| public static func fromName(_ name: String) -> SentryReplayOptions.SentryReplayQuality { | |||
There was a problem hiding this comment.
How bad would this SDK change be @philipphofmann
There was a problem hiding this comment.
I think it wouldn't be ideal but also not terrible. We could still mark it as "do not use this".
If we just need it internally, we could consider using @_spi(Private) (cc @noahsmartin)
armcknight
force-pushed
the
armcknight/test/more-override-config
branch
from
99bb9dd to
3172bce
Compare
armcknight
changed the base branch from
armcknight/test/sample-app-debug-menu
to
armcknight/test/dns-view-in-debug-menu
…t/test/dns-view-in-debug-menu
…t/test/dns-view-in-debug-menu
…/test/more-override-config
…t/test/dns-view-in-debug-menu
…/test/more-override-config
armcknight
requested review from
noahsmartin,
trevor-e,
itaybre and
NicoHinderling
as code owners
…t/test/more-override-config
…t/test/more-override-config
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -66,7 +66,7 @@ public class SentryReplayOptions: NSObject, SentryRedactOptions { | |||
| /** | |||
| * Used by Hybrid SDKs. | |||
| */ | |||
| static func fromName(_ name: String) -> SentryReplayOptions.SentryReplayQuality { | |||
| public static func fromName(_ name: String) -> SentryReplayOptions.SentryReplayQuality { | |||
There was a problem hiding this comment.
I think it wouldn't be ideal but also not terrible. We could still mark it as "do not use this".
If we just need it internally, we could consider using @_spi(Private) (cc @noahsmartin)
| @@ -34,7 +34,7 @@ class MySceneDelegate: NSObject, UIWindowSceneDelegate, ObservableObject { | |||
| var initializedSentry = false | |||
| func sceneDidBecomeActive(_ scene: UIScene) { | |||
| guard !initializedSentry else { return } | |||
| SentrySDK.showFeedbackWidget() | |||
| SentrySDK.feedback.showWidget() | |||
There was a problem hiding this comment.
h: The widget i not showing up for me, I assume that something with the window levels could be the issue, but not sure.
| @@ -33,7 +33,7 @@ class MySceneDelegate: NSObject, UIWindowSceneDelegate, ObservableObject { | |||
| var initializedSentry = false | |||
| func sceneDidBecomeActive(_ scene: UIScene) { | |||
| guard !initializedSentry else { return } | |||
| SentrySDK.showFeedbackWidget() | |||
| SentrySDK.feedback.showWidget() | |||
There was a problem hiding this comment.
h: Same as above, not visible in UI.
|
@philprime It's getting long enough that I can't quite remember why these calls are already in this branch, but I'm pretty sure the reason it's not showing up for SwiftUI is due to this change not having been merged yet: #5223 |
|
@armcknight so what would be the best approach to continue? Merging the PR with the known issue and fixing it then? |
Adding more config option overrides and reorganizing in the yml spec. This originally started when I was moving the Camera sample app to use the sdk wrapper and shared overrides.
TODO
- [ ] Do it again, but for iOS-ObjectiveC, since we need to make sure usage of options from objc compiles, but we don't yet have other objc sample apps, so don't need an objc wrapper just yet#skip-changelog