-
-
Notifications
You must be signed in to change notification settings - Fork 355
test: sample app feature flag improvements #5202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…orrect-version-setting
…s-swift6-xcodegen
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…s-swift6-xcodegen
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…ght/ci/ios-swift-xcodegen
…s-swift6-xcodegen
…os13-swift-xcodegen
…ios-swift-cleanup
…orrect-version-setting
…os15-swiftui-xcodegen
Samples/SentrySampleShared/SentrySampleShared/SampleAppDebugMenu.swift
Outdated
Show resolved
Hide resolved
Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift
Outdated
Show resolved
Hide resolved
Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift
Outdated
Show resolved
Hide resolved
…to armcknight/test/restart-sdk-on-reconfig
Would it be possible to merge the individual PRs directly into |
@philprime This is not that large of a PR and it's for sample apps, just review the whole thing. I also explained the changes in the description. You don't need to go through this with a fine toothed comb, do the sample apps do what the changes suggest? |
I just noticed the same compilation issue occured in #5201 (review) and got fixed there. So I assume it will be fixed in this PR as soon as the #5201 is merged. |
Originally in this PR:
isSessionReplayEnabled
orisViewRendererV2Enabled
, they are coming in test: more override config #5201Merged into this PR:
#skip-changelog