-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): capture envelopes #4535
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 1239.16 ms | 1248.49 ms | 9.33 ms |
5e66a38 | 1209.10 ms | 1233.90 ms | 24.79 ms |
3277f18 | 1229.29 ms | 1248.92 ms | 19.63 ms |
3cba0e8 | 1250.86 ms | 1258.39 ms | 7.53 ms |
7fe37ab | 1228.92 ms | 1243.86 ms | 14.94 ms |
0ecf042 | 1228.25 ms | 1250.67 ms | 22.42 ms |
0970e44 | 1237.32 ms | 1251.53 ms | 14.21 ms |
e773cad | 1221.82 ms | 1240.55 ms | 18.73 ms |
f4a6925 | 1237.29 ms | 1249.35 ms | 12.07 ms |
216bdf9 | 1193.69 ms | 1217.90 ms | 24.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 21.58 KiB | 656.60 KiB | 635.01 KiB |
5e66a38 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
3277f18 | 22.84 KiB | 402.88 KiB | 380.03 KiB |
3cba0e8 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
7fe37ab | 21.58 KiB | 542.28 KiB | 520.70 KiB |
0ecf042 | 21.58 KiB | 631.82 KiB | 610.24 KiB |
0970e44 | 22.32 KiB | 761.50 KiB | 739.18 KiB |
e773cad | 21.58 KiB | 681.75 KiB | 660.17 KiB |
f4a6925 | 21.58 KiB | 706.47 KiB | 684.89 KiB |
216bdf9 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
Previous results on branch: armcknight/feat(user-feedback)/envelope
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
46f819e | 1216.73 ms | 1238.35 ms | 21.61 ms |
3c44525 | 1230.98 ms | 1250.49 ms | 19.51 ms |
3f71d28 | 1231.12 ms | 1253.88 ms | 22.76 ms |
c5dac22 | 1229.73 ms | 1252.24 ms | 22.51 ms |
6fbfc91 | 1237.08 ms | 1256.96 ms | 19.88 ms |
86abdac | 1209.79 ms | 1233.82 ms | 24.02 ms |
68416bc | 1227.29 ms | 1247.86 ms | 20.57 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
46f819e | 22.30 KiB | 759.88 KiB | 737.58 KiB |
3c44525 | 22.32 KiB | 765.14 KiB | 742.82 KiB |
3f71d28 | 22.30 KiB | 759.88 KiB | 737.58 KiB |
c5dac22 | 22.31 KiB | 760.57 KiB | 738.26 KiB |
6fbfc91 | 21.90 KiB | 746.34 KiB | 724.43 KiB |
86abdac | 21.90 KiB | 744.30 KiB | 722.40 KiB |
68416bc | 22.31 KiB | 760.79 KiB | 738.48 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a draft, but I already gave you early feedback.
6f2ddf0
to
5038ff5
Compare
f84c1c7
to
2398c73
Compare
2398c73
to
e548832
Compare
c4c1986
to
48c3f2b
Compare
…and showing up in the dashboard
48c3f2b
to
4dcee7a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift
Outdated
Show resolved
Hide resolved
Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackForm.swift
Outdated
Show resolved
Hide resolved
…feedback)/envelope
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the testing approach seems quite strange to me. I don't want this to block this PR though.
for #4272; #skip-changelog
capture the user feedback in an envelope. currently, an error is required to have been captured, with its event ID supplied in the user feedback object. so, a dummy error is currently created to satisfy this requirement to be able to see them in the dashboard (see linked issue for progress/results)
TODOs