Skip to content

Commit

Permalink
ios-only build requirements needed some places, but actually not for …
Browse files Browse the repository at this point in the history
…SentryFeedback
  • Loading branch information
armcknight committed Dec 13, 2024
1 parent f6689f7 commit 48c3f2b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 2 additions & 0 deletions Sources/Sentry/SentrySDK.m
Original file line number Diff line number Diff line change
Expand Up @@ -410,10 +410,12 @@ + (void)captureFeedback:(SentryFeedback *)feedback
[SentrySDK.currentHub captureFeedback:feedback];
}

#if TARGET_OS_IOS && SENTRY_HAS_UIKIT
+ (void)showUserFeedbackForm
{
// TODO: implement
}
#endif // TARGET_OS_IOS && SENTRY_HAS_UIKIT

+ (void)addBreadcrumb:(SentryBreadcrumb *)crumb
{
Expand Down
2 changes: 2 additions & 0 deletions Sources/Sentry/include/SentryOptions+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ FOUNDATION_EXPORT NSString *const kSentryDefaultEnvironment;
- (BOOL)isContinuousProfilingEnabled;
#endif // SENTRY_TARGET_PROFILING_SUPPORTED

#if TARGET_OS_IOS && SENTRY_HAS_UIKIT
/**
* A block that can be defined that receives a user feedback configuration object to modify.
* @warning This is an experimental feature and may still have bugs.
Expand All @@ -31,6 +32,7 @@ FOUNDATION_EXPORT NSString *const kSentryDefaultEnvironment;
*/
@property (nonatomic, copy, nullable)
SentryUserFeedbackConfigurationBlock configureUserFeedback API_AVAILABLE(ios(13.0));
#endif // TARGET_OS_IOS && SENTRY_HAS_UIKIT

@property (nonatomic, readonly, class) NSArray<Class> *defaultIntegrationClasses;

Expand Down
6 changes: 1 addition & 5 deletions Sources/Swift/Integrations/UserFeedback/SentryFeedback.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import Foundation
#if os(iOS) && !SENTRY_NO_UIKIT
@_implementationOnly import _SentryPrivate
import UIKit
import Foundation

@objcMembers
class SentryFeedback: NSObject, SentrySerializable {
Expand Down Expand Up @@ -63,5 +61,3 @@ class SentryFeedback: NSObject, SentrySerializable {
return items
}
}

#endif // os(iOS) && !SENTRY_NO_UIKIT

0 comments on commit 48c3f2b

Please sign in to comment.