Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ucfirst behavior #6860

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix ucfirst behavior #6860

merged 1 commit into from
Dec 10, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Dec 10, 2024 •
edited by bastianallgeier
Loading

Changelog

Fixes

⚠️ Breaking changes

  • The Str::ucfirst() method no longer lowercases all but the first letter of the text, it only capitalizes the first letter.

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Dec 10, 2024
@afbora afbora added this to the 5.0.0-beta.2 milestone Dec 10, 2024
@afbora afbora requested a review from a team December 10, 2024 11:23
@afbora afbora self-assigned this Dec 10, 2024
@afbora afbora linked an issue Dec 10, 2024 that may be closed by this pull request
ucfirst behavior differs from PHP default #6834
Closed
@bastianallgeier bastianallgeier merged commit cde80bd into v5/develop Dec 10, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/6834-ucfirst-behavior branch December 10, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
5.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

ucfirst behavior differs from PHP default
2 participants
@afbora @bastianallgeier