Merge pull request #6860 from getkirby/fix/6834-ucfirst-behavior

Fix `ucfirst` behavior
getkirby · Dec 10, 2024 · cde80bd · cde80bd
2 parents 720fa68 + 7af14f9
commit cde80bd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/Toolkit/Str.php b/src/Toolkit/Str.php
@@ -1405,7 +1405,7 @@ public static function ucfirst(string|null $string): string
 	{
 		$first = static::substr($string, 0, 1);
 		$rest  = static::substr($string, 1);
-		return static::upper($first) . static::lower($rest);
+		return static::upper($first) . $rest;
 	}
 
 	/**

diff --git a/tests/Toolkit/StrTest.php b/tests/Toolkit/StrTest.php
@@ -1492,7 +1492,10 @@ public function testTrim()
 	public function testUcfirst()
 	{
 		$this->assertSame('Hello world', Str::ucfirst('hello world'));
-		$this->assertSame('Hello world', Str::ucfirst('Hello World'));
+		$this->assertSame('Hello world', Str::ucfirst('Hello world'));
+		$this->assertSame('Hello World', Str::ucfirst('Hello World'));
+		$this->assertSame('HELLO WORLD', Str::ucfirst('HELLO WORLD'));
+		$this->assertSame('Hello WORLD', Str::ucfirst('hello WORLD'));
 	}
 
 	/**