-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 6: Version class improvements and unit tests #6450
Merged
lukasbestle
merged 25 commits into
v5/develop
from
v5/changes/version-class-improvements
Jun 12, 2024
Merged
Changes 6: Version class improvements and unit tests #6450
lukasbestle
merged 25 commits into
v5/develop
from
v5/changes/version-class-improvements
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianallgeier
force-pushed
the
v5/changes/version-class-improvements
branch
3 times, most recently
from
May 21, 2024 11:31
5cea85b
to
00105f6
Compare
This was referenced May 21, 2024
bastianallgeier
force-pushed
the
v5/changes/version-class-improvements
branch
from
May 22, 2024 12:32
77c290e
to
c336cd3
Compare
bastianallgeier
changed the base branch from
v5/develop
to
v5/changes/content-storage-handler-abstract
May 22, 2024 12:33
13 tasks
bastianallgeier
force-pushed
the
v5/changes/content-storage-handler-abstract
branch
from
June 5, 2024 09:05
f3528f1
to
53629c8
Compare
bastianallgeier
force-pushed
the
v5/changes/version-class-improvements
branch
from
June 5, 2024 09:07
c336cd3
to
dd746cb
Compare
Base automatically changed from
v5/changes/content-storage-handler-abstract
to
v5/develop
June 10, 2024 19:30
lukasbestle
reviewed
Jun 10, 2024
Co-authored-by: Lukas Bestle <[email protected]>
bastianallgeier
force-pushed
the
v5/changes/version-class-improvements
branch
from
June 11, 2024 14:15
7ab9839
to
62aee1b
Compare
This was referenced Jun 11, 2024
lukasbestle
reviewed
Jun 11, 2024
Co-authored-by: Lukas Bestle <[email protected]>
Co-authored-by: Lukas Bestle <[email protected]>
Co-authored-by: Lukas Bestle <[email protected]>
@lukasbestle I think we can ignore the coverage. Codecov is considering the Language::single line uncovered although it clearly is covered by multiple tests. |
It was covered, but not marked as covered 😉 |
lukasbestle
approved these changes
Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Refactoring
ContentStorage
toVersion
where it makes senseVersion::contentFile
Version::delete
to always delete all languagesVersion::touchLanguage
Language
objects to storage methods::modified
if a version does not exist.Outlook
VersionTest::setUpSingleLanguage
andVersionTest::setUpMultiLanguage
methods turn out to be super useful. Changes 7: Move ContentStorage methods to ContentStorageHandler #6454 will implement a newKirby\Content\TestCase
class with those setup methods and thePlainTextContentStorageHandlerTest
andVersionTest
classes will both extend them, which makes the tests a lot easier. We will also be able to use this for theMemoryContentStorageHandlerTest
class later Changes 10: New MemoryContentStorageHandler #6457Breaking changes
None
Ready?
For review team
Add changes & docs to release notes draft in Notion(not relevant as theVersion
class is added in v5 alpha 1)