-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes 15: More ContentStorageHandler class methods #6500
Merged
bastianallgeier
merged 5 commits into
v5/develop
from
v5/changes/15-more-content-storage-handler-methods
Jun 27, 2024
Merged
Changes 15: More ContentStorageHandler class methods #6500
bastianallgeier
merged 5 commits into
v5/develop
from
v5/changes/15-more-content-storage-handler-methods
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 21, 2024 09:34
a98b2fb
to
16c3da1
Compare
bastianallgeier
force-pushed
the
v5/changes/15-more-content-storage-handler-methods
branch
from
June 21, 2024 09:35
465f9f6
to
015bb05
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 21, 2024 10:20
16c3da1
to
a35cc52
Compare
bastianallgeier
force-pushed
the
v5/changes/15-more-content-storage-handler-methods
branch
from
June 21, 2024 10:20
015bb05
to
8a58d8d
Compare
lukasbestle
approved these changes
Jun 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not quite sure how we can clean up the methods in ContentStorageHandler
and this makes the interface idea harder, but let's see. Problem for future Basti and Lukas when everything else has settled :)
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 24, 2024 09:30
a35cc52
to
aa92112
Compare
bastianallgeier
force-pushed
the
v5/changes/15-more-content-storage-handler-methods
branch
from
June 24, 2024 09:30
33e5993
to
5a6ae64
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 24, 2024 10:04
aa92112
to
b36eef8
Compare
bastianallgeier
force-pushed
the
v5/changes/15-more-content-storage-handler-methods
branch
from
June 24, 2024 10:04
5a6ae64
to
07f28e4
Compare
bastianallgeier
force-pushed
the
v5/changes/14-prop-fixes
branch
from
June 25, 2024 08:39
b36eef8
to
e0acee4
Compare
bastianallgeier
force-pushed
the
v5/changes/15-more-content-storage-handler-methods
branch
from
June 25, 2024 08:39
07f28e4
to
b367b05
Compare
This was referenced Jun 25, 2024
bastianallgeier
deleted the
v5/changes/15-more-content-storage-handler-methods
branch
June 27, 2024 08:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Reasoning
This PR is grouping together additional
ContentStorageHandler
changes that are needed in later steps. It just tries to keep future PRs more manageable and also helps to keep code coverage and unit tests under control.Features
ContentStorageHandler::model
method to access the parent model. We need this later when working with clones in model actions.ContentStorageHandler::from
method. This method will take an existingContentStorageHandler
instance and create a new instance by copying over the same versions. This is needed later when we convert a model fromPlainTextContentStorageHandler
toMemoryContentStorageHandler
for example.Breaking changes
None expected
Ready?
For review team