Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 15: More ContentStorageHandler class methods #6500

Merged

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Jun 20, 2024

This PR …

Reasoning

This PR is grouping together additional ContentStorageHandler changes that are needed in later steps. It just tries to keep future PRs more manageable and also helps to keep code coverage and unit tests under control.

Features

  • New ContentStorageHandler::model method to access the parent model. We need this later when working with clones in model actions.
  • New ContentStorageHandler::from method. This method will take an existing ContentStorageHandler instance and create a new instance by copying over the same versions. This is needed later when we convert a model from PlainTextContentStorageHandler to MemoryContentStorageHandler for example.

Breaking changes

None expected

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier force-pushed the v5/changes/14-prop-fixes branch from a98b2fb to 16c3da1 Compare June 21, 2024 09:34
@bastianallgeier bastianallgeier force-pushed the v5/changes/15-more-content-storage-handler-methods branch from 465f9f6 to 015bb05 Compare June 21, 2024 09:35
@bastianallgeier bastianallgeier force-pushed the v5/changes/14-prop-fixes branch from 16c3da1 to a35cc52 Compare June 21, 2024 10:20
@bastianallgeier bastianallgeier force-pushed the v5/changes/15-more-content-storage-handler-methods branch from 015bb05 to 8a58d8d Compare June 21, 2024 10:20
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not quite sure how we can clean up the methods in ContentStorageHandler and this makes the interface idea harder, but let's see. Problem for future Basti and Lukas when everything else has settled :)

tests/Content/ContentStorageHandlerTest.php Show resolved Hide resolved
@bastianallgeier bastianallgeier force-pushed the v5/changes/14-prop-fixes branch from a35cc52 to aa92112 Compare June 24, 2024 09:30
@bastianallgeier bastianallgeier force-pushed the v5/changes/15-more-content-storage-handler-methods branch from 33e5993 to 5a6ae64 Compare June 24, 2024 09:30
@bastianallgeier bastianallgeier force-pushed the v5/changes/14-prop-fixes branch from aa92112 to b36eef8 Compare June 24, 2024 10:04
@bastianallgeier bastianallgeier force-pushed the v5/changes/15-more-content-storage-handler-methods branch from 5a6ae64 to 07f28e4 Compare June 24, 2024 10:04
@bastianallgeier bastianallgeier force-pushed the v5/changes/14-prop-fixes branch from b36eef8 to e0acee4 Compare June 25, 2024 08:39
@bastianallgeier bastianallgeier force-pushed the v5/changes/15-more-content-storage-handler-methods branch from 07f28e4 to b367b05 Compare June 25, 2024 08:39
Base automatically changed from v5/changes/14-prop-fixes to v5/develop June 27, 2024 08:24
@bastianallgeier bastianallgeier marked this pull request as ready for review June 27, 2024 08:24
@bastianallgeier bastianallgeier merged commit f9d11b7 into v5/develop Jun 27, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/15-more-content-storage-handler-methods branch June 27, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants