-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor deprecation warning tests #6093
Refactor deprecation warning tests #6093
Conversation
Looking into the CI failure. Something seems to be off as my commit worked locally before but now works neither in CI nor locally. |
We need to pop exactly as many error handlers off the stack as we added, even if e.g. the `assertError()` method was called multiple times
f5f9a89
to
0cbf7c8
Compare
@distantnative Reverted my earlier commit as it broke subsequent tests, but I couldn't find out why. From reading the code, this test should not need to restore the error handler as the one set inside kirby/tests/Cms/Helpers/HelpersTest.php Lines 198 to 207 in ba8e9e5
Can you remember why you added the |
PHPUnit 10 won't throw errors anymore, which is why we need to switch to a different test setup for our deprecation errors