-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPUnit 10 #6059
PHPUnit 10 #6059
Conversation
001a254
to
92f461d
Compare
05a15b6
to
318118e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, nice work. 👍
Love that it uncovered core issues. Could you please add those to the release note snippet as well?
Co-authored-by: Lukas Bestle <[email protected]>
Already configured that way in the XML config
Ensures that broken tests are noticed early
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the PHPUnit config with some improvements from the defaults. @distantnative Could you please take a look if the changes make sense?
Since tests are skipped if the requirements are not met locally
Some of the changes you see are because with PHPUnit 9 PHP warnings would be converted to Exceptions. So falsely, we put some throw-catch logic in places to deal with though. But in reality those were just warnings that would not be matched (and it showed now with PHPUnit 10), so we need to refactor some smaller bits here and there.
Features
A::implode()
method that also handles nested arraysFixed
F::size()
with non-existing fileSession
dataV::message()
with nested arraysHousekeeping