Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 10 #6059

Merged
merged 17 commits into from
Dec 31, 2023
Merged

PHPUnit 10 #6059

merged 17 commits into from
Dec 31, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Dec 9, 2023

Some of the changes you see are because with PHPUnit 9 PHP warnings would be converted to Exceptions. So falsely, we put some throw-catch logic in places to deal with though. But in reality those were just warnings that would not be matched (and it showed now with PHPUnit 10), so we need to refactor some smaller bits here and there.

Features

  • New A::implode() method that also handles nested arrays

Fixed

  • Fixed PHP warning for structure fields without subfields
  • Fixed PHP warning for F::size() with non-existing file
  • Fixed PHP warning for unserializing Session data
  • Fixed PHP warning for V::message() with nested arrays

Housekeeping

  • Upgraded unit testing to PHPUnit 10

@distantnative distantnative added the type: tests 🧪 Is about missing tests; increases test coverage or improves tests label Dec 9, 2023
@distantnative distantnative self-assigned this Dec 9, 2023
@distantnative distantnative force-pushed the enhancement/phpunit-10 branch 5 times, most recently from 001a254 to 92f461d Compare December 31, 2023 09:48
@distantnative distantnative marked this pull request as ready for review December 31, 2023 11:31
@distantnative distantnative requested a review from a team December 31, 2023 11:31
@distantnative distantnative added this to the 4.1.0 milestone Dec 31, 2023
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice work. 👍

Love that it uncovered core issues. Could you please add those to the release note snippet as well?

src/Toolkit/A.php Outdated Show resolved Hide resolved
src/Toolkit/A.php Outdated Show resolved Hide resolved
lukasbestle
lukasbestle previously approved these changes Dec 31, 2023
Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PHPUnit config with some improvements from the defaults. @distantnative Could you please take a look if the changes make sense?

Since tests are skipped if the requirements are not met locally
@distantnative distantnative merged commit 081b0ae into develop-minor Dec 31, 2023
12 checks passed
@distantnative distantnative deleted the enhancement/phpunit-10 branch December 31, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: tests 🧪 Is about missing tests; increases test coverage or improves tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants