Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit: static providers #6081

Merged
merged 5 commits into from
Dec 23, 2023
Merged

PHPUnit: static providers #6081

merged 5 commits into from
Dec 23, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Dec 19, 2023 •
edited
Loading

PHPUnit 10 will require provider methods to be static.

This PR converts most of our test provider methods. As a first step.

@distantnative distantnative self-assigned this Dec 19, 2023
@distantnative distantnative added type: refactoring ♻️ Is about bad code; cleans up code type: tests 🧪 Is about missing tests; increases test coverage or improves tests labels Dec 19, 2023
@distantnative distantnative added this to the 4.1.0 milestone Dec 19, 2023
@distantnative distantnative requested a review from a team December 19, 2023 19:13
@distantnative distantnative mentioned this pull request Dec 19, 2023
Merged
@distantnative distantnative merged commit aad45f8 into develop-minor Dec 23, 2023
12 checks passed
@distantnative distantnative deleted the refactor/phpunit-static-providers branch December 23, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasbestle lukasbestle lukasbestle approved these changes

Assignees

@distantnative distantnative

Labels
type: refactoring ♻️ Is about bad code; cleans up code type: tests 🧪 Is about missing tests; increases test coverage or improves tests
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @lukasbestle