New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix anchors.add() being called too late #25

Merged

rhukster merged 1 commit into getgrav:develop from pamtbaau:develop

Jun 13, 2021

Contributor

pamtbaau commented Jun 13, 2021 •

edited

Loading

This PR will fix issue H4 hyperlink won't jump to it's page position #897 about anchors not being jumped to by the browser.

See remark at AnchorJS:

Don't add anchors on later events, like $(document).ready() or window.onload as some browsers will attempt to jump to your ID before AnchorJS can add it to the page. For more details, see github issue #69.


          Fix anchors.add() being called too late

0daaac5

pamtbaau mentioned this pull request

H4 hyperlink won't jump to it's page position getgrav/grav-learn#897

Open

rhukster merged commit 7e5e85d into getgrav:develop

Member

rhukster commented Jun 13, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet